From: Joe Perches <joe@perches.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: David Miller <davem@davemloft.net>,
chas@cmf.nrl.navy.mil, linux-atm-general@lists.sourceforge.net,
netdev@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] atm: dereference of he_dev->rbps_virt in he_init_group()
Date: Sat, 19 Sep 2009 11:27:27 -0700 [thread overview]
Message-ID: <1253384847.2638.4.camel@Joe-Laptop.home> (raw)
In-Reply-To: <4AB51FE7.7030509@gmail.com>
On Sat, 2009-09-19 at 20:16 +0200, Roel Kluin wrote:
> + int i, ret;
> + ret = -ENOMEM;
> + ret = -ENOMEM;
> + ret = -ENOMEM;
> + ret = -ENOMEM;
> + ret = -ENOMEM;
> + ret = -ENOMEM;
> + ret = -ENOMEM;
> + ret = -ENOMEM;
> +out_destroy_rbps_pool:
> + pci_pool_destroy(he_dev->rbps_pool);
> + return ret;
It looks as if it'd be clearer to not use variable ret and
simply return -ENOMEM after the out_destroy_rbps_pool label.
next prev parent reply other threads:[~2009-09-19 18:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-29 18:56 [PATCH] atm: dereference of he_dev->rbps_virt in he_init_group() Roel Kluin
2009-08-29 18:59 ` Roel Kluin
2009-09-03 6:25 ` David Miller
2009-09-05 12:35 ` Roel Kluin
2009-09-11 19:37 ` David Miller
2009-09-11 19:51 ` David Miller
2009-09-19 18:16 ` Roel Kluin
2009-09-19 18:27 ` Joe Perches [this message]
2009-09-20 17:11 ` Roel Kluin
2009-09-22 21:25 ` David Miller
2009-09-26 13:20 ` Roel Kluin
2009-09-27 3:26 ` David Miller
2009-09-28 8:58 ` Roel Kluin
2009-09-28 19:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253384847.2638.4.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=chas@cmf.nrl.navy.mil \
--cc=davem@davemloft.net \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.