Re: [LTP] [PATCH 3/5] fsstress: fix memory leaks

[Subrata Modak <subrata@linux.vnet.ibm.com>]

On Sun, 2009-09-27 at 02:46 +0400, Andrew Vagin wrote: 
> ==11424== 156 bytes in 1 blocks are definitely lost in loss record 2 of 2
> ==11424==    at 0x4A0763E: malloc (vg_replace_malloc.c:207)
> ==11424==    by 0x402E4C: make_freq_table (fsstress.c:986)
> ==11424==    by 0x401C26: main (fsstress.c:410)
> 
> make_freq_table is executed on each iterations, but freq_table is not
> changed during test, so this patch moves it from the loop
> 
> Signed-off-by: Andrew Vagin <avagin@gmail.com>

Thanks.

Regards--
Subrata

> ---
>  testcases/kernel/fs/fsstress/fsstress.c |   28 +++++++++++++++-------------
>  1 files changed, 15 insertions(+), 13 deletions(-)
> 
> diff --git a/testcases/kernel/fs/fsstress/fsstress.c b/testcases/kernel/fs/fsstress/fsstress.c
> index 5ada3d8..715c08d 100644
> --- a/testcases/kernel/fs/fsstress/fsstress.c
> +++ b/testcases/kernel/fs/fsstress/fsstress.c
> @@ -375,21 +375,24 @@ int main(int argc, char **argv)
>  			break;
>  		}
>  	}
> -	while ( (loopcntr <= loops) || (loops == 0) )
> -	{
> -		if (no_xfs && errtag) {
> -			fprintf(stderr, "error injection only works on XFS\n");
> -			exit(1);
> -		}
> 
> -		if (no_xfs) {
> -			int i;
> -			for (i = 0; ops+i < ops_end; ++i) {
> -				if (ops[i].isxfs)
> -					ops[i].freq = 0;
> -			}
> +	if (no_xfs && errtag) {
> +		fprintf(stderr, "error injection only works on XFS\n");
> +		exit(1);
> +	}
> +
> +	if (no_xfs) {
> +		int i;
> +		for (i = 0; ops+i < ops_end; ++i) {
> +			if (ops[i].isxfs)
> +				ops[i].freq = 0;
>  		}
> +	}
> 
> +	make_freq_table();
> +
> +	while ( (loopcntr <= loops) || (loops == 0) )
> +	{
>  		if (!dirname) {
>  			/* no directory specified */
>  			if (!nousage) usage();
> @@ -407,7 +410,6 @@ int main(int argc, char **argv)
>  			maxfsize = (off64_t)MAXFSIZE32;
>  		else
>  			maxfsize = (off64_t)MAXFSIZE;
> -		make_freq_table();
>  		dcache_init();
>  		setlinebuf(stdout);
>  		if (!seed) {


------------------------------------------------------------------------------
Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
http://p.sf.net/sfu/devconf
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list