From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mswe9-000316-G5 for qemu-devel@nongnu.org; Wed, 30 Sep 2009 06:42:57 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mswe4-0002xm-6j for qemu-devel@nongnu.org; Wed, 30 Sep 2009 06:42:56 -0400 Received: from [199.232.76.173] (port=41724 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mswe2-0002xF-Hg for qemu-devel@nongnu.org; Wed, 30 Sep 2009 06:42:50 -0400 Received: from mail.valinux.co.jp ([210.128.90.3]:55565) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mswe1-0000Id-OI for qemu-devel@nongnu.org; Wed, 30 Sep 2009 06:42:50 -0400 From: Isaku Yamahata Date: Wed, 30 Sep 2009 19:18:09 +0900 Message-Id: <1254305917-14784-34-git-send-email-yamahata@valinux.co.jp> In-Reply-To: <1254305917-14784-1-git-send-email-yamahata@valinux.co.jp> References: <1254305917-14784-1-git-send-email-yamahata@valinux.co.jp> Subject: [Qemu-devel] [PATCH 33/61] pci: use the symbolic constant, PCI_ROM_ADDRESS_ENABLE instead of 1. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, anthony@codemonkey.ws Cc: yamahata@valinux.co.jp use the symbolic constant, PCI_ROM_ADDRESS_ENABLE instead of 1. Signed-off-by: Isaku Yamahata --- hw/pci.c | 2 +- hw/pci.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 29bca12..954fc57 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -482,7 +482,7 @@ void pci_register_bar(PCIDevice *pci_dev, int region_num, if (region_num == PCI_ROM_SLOT) { addr = 0x30; /* ROM enable bit is writeable */ - wmask |= 1; + wmask |= PCI_ROM_ADDRESS_ENABLE; } else { addr = 0x10 + region_num * 4; } diff --git a/hw/pci.h b/hw/pci.h index e3f5df8..ce72020 100644 --- a/hw/pci.h +++ b/hw/pci.h @@ -141,6 +141,8 @@ static inline int pci_bar_is_64bit(const PCIIORegion *r) #define PCI_SUBVENDOR_ID 0x2c /* obsolete, use PCI_SUBSYSTEM_VENDOR_ID */ #define PCI_SUBDEVICE_ID 0x2e /* obsolete, use PCI_SUBSYSTEM_ID */ +#define PCI_ROM_ADDRESS_ENABLE 0x01 + /* Bits in the PCI Status Register (PCI 2.3 spec) */ #define PCI_STATUS_RESERVED1 0x007 #define PCI_STATUS_INT_STATUS 0x008 -- 1.6.0.2