From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MtHsd-0003Nm-KW
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 05:23:19 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MtHsY-0003KT-KT
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 05:23:18 -0400
Received: from [199.232.76.173] (port=36101 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MtHsY-0003K9-6e
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 05:23:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25638)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <markmc@redhat.com>) id 1MtHsX-0002yE-NE
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 05:23:14 -0400
Subject: Re: [Qemu-devel] [PATCH 07/12] BACKPORT: vnc: fix copyrect screen
	corruption
From: Mark McLoughlin <markmc@redhat.com>
In-Reply-To: <1251291946-25821-8-git-send-email-glommer@redhat.com>
References: <1251291946-25821-1-git-send-email-glommer@redhat.com>
	<1251291946-25821-2-git-send-email-glommer@redhat.com>
	<1251291946-25821-3-git-send-email-glommer@redhat.com>
	<1251291946-25821-4-git-send-email-glommer@redhat.com>
	<1251291946-25821-5-git-send-email-glommer@redhat.com>
	<1251291946-25821-6-git-send-email-glommer@redhat.com>
	<1251291946-25821-7-git-send-email-glommer@redhat.com>
	<1251291946-25821-8-git-send-email-glommer@redhat.com>
Content-Type: text/plain
Date: Thu, 01 Oct 2009 10:21:40 +0100
Message-Id: <1254388900.2920.27.camel@blaa>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Reply-To: Mark McLoughlin <markmc@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

Hey,

On Wed, 2009-08-26 at 09:05 -0400, Glauber Costa wrote:
> From: Gerd Hoffmann <kraxel@redhat.com>
> 
> When sending a copyrect command to the vnc client, we must also update
> the local server surface.  Otherwise the server's and the client's idea
> of the screen content run out of sync and screen updates don't work
> correctly.
> 
> [ backport: uses ds_get_data() instead of direct dereference ]

We have reports from two Fedora 11 users that this fix makes things
worse:

  https://bugzilla.redhat.com/503156

Cheers,
Mark.