From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757862AbZJDTsi (ORCPT ); Sun, 4 Oct 2009 15:48:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757664AbZJDTsh (ORCPT ); Sun, 4 Oct 2009 15:48:37 -0400 Received: from mail.gmx.net ([213.165.64.20]:39902 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1757601AbZJDTsh (ORCPT ); Sun, 4 Oct 2009 15:48:37 -0400 X-Authenticated: #14349625 X-Provags-ID: V01U2FsdGVkX1/0yHhV9Hn0nJSzlnLfpNEPr5eHvvqdkIIHlSbLBE 865YESi97PSzjh Subject: Re: Do not overload dispatch queue (Was: Re: IO scheduler based IO controller V10) From: Mike Galbraith To: Jens Axboe Cc: Vivek Goyal , Ingo Molnar , Linus Torvalds , Ulrich Lukas , linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, dm-devel@redhat.com, nauman@google.com, dpshah@google.com, lizf@cn.fujitsu.com, mikew@google.com, fchecconi@gmail.com, paolo.valente@unimore.it, ryov@valinux.co.jp, fernando@oss.ntt.co.jp, jmoyer@redhat.com, dhaval@linux.vnet.ibm.com, balbir@linux.vnet.ibm.com, righi.andrea@gmail.com, m-ikeda@ds.jp.nec.com, agk@redhat.com, akpm@linux-foundation.org, peterz@infradead.org, jmarchan@redhat.com, riel@redhat.com In-Reply-To: <20091004183822.GF26573@kernel.dk> References: <1254581496.8293.8.camel@marge.simson.net> <20091003151445.GF31616@kernel.dk> <1254585420.7539.2.camel@marge.simson.net> <20091003173532.GG31616@kernel.dk> <1254596864.7153.9.camel@marge.simson.net> <20091003192321.GA26573@kernel.dk> <1254599386.7153.46.camel@marge.simson.net> <1254653434.7237.18.camel@marge.simson.net> <20091004173901.GD26573@kernel.dk> <1254680622.27889.2.camel@marge.simson.net> <20091004183822.GF26573@kernel.dk> Content-Type: text/plain Date: Sun, 04 Oct 2009 21:47:18 +0200 Message-Id: <1254685638.7637.6.camel@marge.simson.net> Mime-Version: 1.0 X-Mailer: Evolution 2.24.1.1 Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2009-10-04 at 20:38 +0200, Jens Axboe wrote: > On Sun, Oct 04 2009, Mike Galbraith wrote: > > On Sun, 2009-10-04 at 19:39 +0200, Jens Axboe wrote: > > > > > So I'll commit a change that doesn't do the delay at all, basically it > > > just offset the current code by one slice. > > > > Ok, when it hits block-for-linus, I'll take it out for a spin. > > It's committed: > > http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=e00c54c36ac2024c3a8a37432e2e2698ff849594 Looks like a keeper to me :) -Mike dd vs konsole -e exit Avg 1.70 1.94 1.32 1.89 1.87 1.7 fairness=1 overload_delay=1 1.55 1.79 1.38 1.53 1.57 1.5 desktop=1 +last_end_sync 1.09 0.87 1.11 0.96 1.11 1.0 block-for-linus-8e29675 1.29 2.18 1.16 1.21 1.24 1.4 block-for-linus-e00c54c concurrent git test Avg 108.12 106.33 106.34 97.00 106.52 104.8 1.000 virgin 89.81 88.82 91.56 96.57 89.38 91.2 .870 desktop=1 +last_end_sync 92.61 94.60 92.35 93.17 94.05 93.3 .890 blk-for-linus-8e29675 88.73 89.02 88.10 90.84 88.30 88.9 .848 blk-for-linus-e00c54c read vs write test desktop=0 Avg elapsed 98.23 91.97 91.77 93.9 sec 1.000 30s-dd-read 48.5 49.6 49.1 49.0 mb/s 1.000 30s-dd-write 23.1 27.3 31.3 27.2 1.000 dd-read-total 49.4 50.1 49.6 49.7 1.000 dd-write-total 34.5 34.9 34.9 34.7 1.000 desktop=1 pop 8e296755 Avg elapsed 93.30 92.77 90.11 92.0 .979 30s-dd-read 50.5 50.4 51.8 50.9 1.038 30s-dd-write 22.7 26.4 27.7 25.6 .941 dd-read-total 51.2 50.1 51.6 50.9 1.024 dd-write-total 34.2 34.5 35.6 34.7 1.000 desktop=1 push 8e296755 Avg elapsed 104.51 104.52 101.20 103.4 1.101 30s-dd-read 43.0 43.6 44.5 43.7 .891 30s-dd-write 21.4 23.9 28.9 24.7 .908 dd-read-total 42.9 43.0 43.5 43.1 .867 dd-write-total 30.4 30.3 31.5 30.7 .884 latency=1 push e00c54c Avg elapsed 90.03 93.03 91.68 91.5 .974 30s-dd-read 53.1 54.8 51.3 53.0 1.081 30s-dd-write 20.0 23.3 28.2 23.8 .875 dd-read-total 53.7 54.0 52.6 53.4 1.074 dd-write-total 35.5 34.2 34.9 34.8 1.002 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Galbraith Subject: Re: Do not overload dispatch queue (Was: Re: IO scheduler based IO controller V10) Date: Sun, 04 Oct 2009 21:47:18 +0200 Message-ID: <1254685638.7637.6.camel@marge.simson.net> References: <1254581496.8293.8.camel@marge.simson.net> <20091003151445.GF31616@kernel.dk> <1254585420.7539.2.camel@marge.simson.net> <20091003173532.GG31616@kernel.dk> <1254596864.7153.9.camel@marge.simson.net> <20091003192321.GA26573@kernel.dk> <1254599386.7153.46.camel@marge.simson.net> <1254653434.7237.18.camel@marge.simson.net> <20091004173901.GD26573@kernel.dk> <1254680622.27889.2.camel@marge.simson.net> <20091004183822.GF26573@kernel.dk> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20091004183822.GF26573@kernel.dk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Jens Axboe Cc: dhaval@linux.vnet.ibm.com, peterz@infradead.org, dm-devel@redhat.com, dpshah@google.com, agk@redhat.com, balbir@linux.vnet.ibm.com, paolo.valente@unimore.it, jmarchan@redhat.com, fernando@oss.ntt.co.jp, Ulrich Lukas , mikew@google.com, jmoyer@redhat.com, nauman@google.com, Ingo Molnar , Vivek Goyal , m-ikeda@ds.jp.nec.com, riel@redhat.com, lizf@cn.fujitsu.com, fchecconi@gmail.com, containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, righi.andrea@gmail.com, Linus Torvalds List-Id: dm-devel.ids On Sun, 2009-10-04 at 20:38 +0200, Jens Axboe wrote: > On Sun, Oct 04 2009, Mike Galbraith wrote: > > On Sun, 2009-10-04 at 19:39 +0200, Jens Axboe wrote: > > > > > So I'll commit a change that doesn't do the delay at all, basically it > > > just offset the current code by one slice. > > > > Ok, when it hits block-for-linus, I'll take it out for a spin. > > It's committed: > > http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=e00c54c36ac2024c3a8a37432e2e2698ff849594 Looks like a keeper to me :) -Mike dd vs konsole -e exit Avg 1.70 1.94 1.32 1.89 1.87 1.7 fairness=1 overload_delay=1 1.55 1.79 1.38 1.53 1.57 1.5 desktop=1 +last_end_sync 1.09 0.87 1.11 0.96 1.11 1.0 block-for-linus-8e29675 1.29 2.18 1.16 1.21 1.24 1.4 block-for-linus-e00c54c concurrent git test Avg 108.12 106.33 106.34 97.00 106.52 104.8 1.000 virgin 89.81 88.82 91.56 96.57 89.38 91.2 .870 desktop=1 +last_end_sync 92.61 94.60 92.35 93.17 94.05 93.3 .890 blk-for-linus-8e29675 88.73 89.02 88.10 90.84 88.30 88.9 .848 blk-for-linus-e00c54c read vs write test desktop=0 Avg elapsed 98.23 91.97 91.77 93.9 sec 1.000 30s-dd-read 48.5 49.6 49.1 49.0 mb/s 1.000 30s-dd-write 23.1 27.3 31.3 27.2 1.000 dd-read-total 49.4 50.1 49.6 49.7 1.000 dd-write-total 34.5 34.9 34.9 34.7 1.000 desktop=1 pop 8e296755 Avg elapsed 93.30 92.77 90.11 92.0 .979 30s-dd-read 50.5 50.4 51.8 50.9 1.038 30s-dd-write 22.7 26.4 27.7 25.6 .941 dd-read-total 51.2 50.1 51.6 50.9 1.024 dd-write-total 34.2 34.5 35.6 34.7 1.000 desktop=1 push 8e296755 Avg elapsed 104.51 104.52 101.20 103.4 1.101 30s-dd-read 43.0 43.6 44.5 43.7 .891 30s-dd-write 21.4 23.9 28.9 24.7 .908 dd-read-total 42.9 43.0 43.5 43.1 .867 dd-write-total 30.4 30.3 31.5 30.7 .884 latency=1 push e00c54c Avg elapsed 90.03 93.03 91.68 91.5 .974 30s-dd-read 53.1 54.8 51.3 53.0 1.081 30s-dd-write 20.0 23.3 28.2 23.8 .875 dd-read-total 53.7 54.0 52.6 53.4 1.074 dd-write-total 35.5 34.2 34.9 34.8 1.002