Re: [GIT PULL] SCSI fixes for 2.6.32-rc3

From: Daniel Walker <dwalker@fifo99.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@suse.de>, Theodore Tso <tytso@mit.edu>,
	James Bottomley <James.Bottomley@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Jing Huang <huangj@brocade.com>
Subject: Re: [GIT PULL] SCSI fixes for 2.6.32-rc3
Date: Fri, 09 Oct 2009 06:10:10 -0700	[thread overview]
Message-ID: <1255093810.18167.398.camel@desktop> (raw)
In-Reply-To: <20091009091538.GA4154@elte.hu>

On Fri, 2009-10-09 at 11:15 +0200, Ingo Molnar wrote:
> 
> I dont know what's the current mainline inclusion quality threshold for 
> non-staging Linux drivers - it might be ok. Also, the driver commit has 
> been rebased a few days ago which makes it hard to see its stability 
> track record.
> 
> 	Ingo
> 
> --------------->
> ERROR: return is not a function, parentheses are not required
> #191: FILE: fcbuild.c:191:
> +			return (FC_PARSE_BUSY);

The author submitted a basic style clean up here,

http://patchwork.kernel.org/patch/50161/

It was a series that did the whole driver.. I'm not sure why those
patches aren't included, but at least there was an attempt at cleaning
the driver up..

Daniel