All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: Carsten Otte <cotte@de.ibm.com>, hare@suse.de
Subject: [Qemu-devel] [PATCH 8/9] Set default console to virtio on S390x
Date: Mon, 19 Oct 2009 16:37:38 +0200	[thread overview]
Message-ID: <1255963059-10298-9-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1255963059-10298-8-git-send-email-agraf@suse.de>

All "normal" system emulation targets in qemu I'm aware of display output
on either VGA or serial output.

Our S390x virtio machine doesn't have such kind of legacy hardware. So
instead we need to default to a virtio console.

I'm not particularly proud of this patch. It would be a lot better to
have something in the machine description that tells us about the default
terminal.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 vl.c |   26 ++++++++++++++++++++++++++
 1 files changed, 26 insertions(+), 0 deletions(-)

diff --git a/vl.c b/vl.c
index 96838f8..f3654ff 100644
--- a/vl.c
+++ b/vl.c
@@ -4818,6 +4818,20 @@ int main(int argc, char **argv, char **envp)
     cyls = heads = secs = 0;
     translation = BIOS_ATA_TRANSLATION_AUTO;
 
+#ifdef TARGET_S390X
+    for(i = 0; i < MAX_SERIAL_PORTS; i++)
+        serial_devices[i] = NULL;
+    serial_device_index = 0;
+
+    for(i = 0; i < MAX_PARALLEL_PORTS; i++)
+        parallel_devices[i] = NULL;
+    parallel_device_index = 0;
+
+    virtio_consoles[0] = "mon:stdio";
+    for(i = 1; i < MAX_VIRTIO_CONSOLES; i++)
+        virtio_consoles[i] = NULL;
+    virtio_console_index = 0;
+#else
     serial_devices[0] = "vc:80Cx24C";
     for(i = 1; i < MAX_SERIAL_PORTS; i++)
         serial_devices[i] = NULL;
@@ -4831,6 +4845,7 @@ int main(int argc, char **argv, char **envp)
     for(i = 0; i < MAX_VIRTIO_CONSOLES; i++)
         virtio_consoles[i] = NULL;
     virtio_console_index = 0;
+#endif
 
     monitor_devices[0] = "vc:80Cx24C";
     for (i = 1; i < MAX_MONITOR_DEVICES; i++) {
@@ -5709,6 +5724,17 @@ int main(int argc, char **argv, char **envp)
                 break;
             }
         }
+        for (i = 0; i < MAX_VIRTIO_CONSOLES; i++) {
+            const char *devname = virtio_consoles[i];
+            if (devname && !strcmp(devname,"mon:stdio")) {
+                monitor_devices[0] = NULL;
+                break;
+            } else if (devname && !strcmp(devname,"stdio")) {
+                monitor_devices[0] = NULL;
+                virtio_consoles[i] = "mon:stdio";
+                break;
+            }
+        }
     }
 
     if (nb_numa_nodes > 0) {
-- 
1.6.0.2

  reply	other threads:[~2009-10-19 14:37 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-19 14:37 [Qemu-devel] [PATCH 0/9] S390x KVM support Alexander Graf
2009-10-19 14:37 ` [Qemu-devel] [PATCH 1/9] Export function for VA defined ram allocation Alexander Graf
2009-10-19 14:37   ` [Qemu-devel] [PATCH 2/9] Add KVM support for S390x Alexander Graf
2009-10-19 14:37     ` [Qemu-devel] [PATCH 3/9] Add support for S390x system emulation Alexander Graf
2009-10-19 14:37       ` [Qemu-devel] [PATCH 4/9] Add S390x virtio machine bus Alexander Graf
2009-10-19 14:37         ` [Qemu-devel] [PATCH 5/9] Add S390x virtio machine description Alexander Graf
2009-10-19 14:37           ` [Qemu-devel] [PATCH 6/9] S390 GDB stub Alexander Graf
2009-10-19 14:37             ` [Qemu-devel] [PATCH 7/9] Implement early printk in virtio-console Alexander Graf
2009-10-19 14:37               ` Alexander Graf [this message]
2009-10-19 14:37                 ` [Qemu-devel] [PATCH 9/9] Move mp_state to CPU_COMMON Alexander Graf
2009-10-19 19:48                 ` [Qemu-devel] [PATCH 8/9] Set default console to virtio on S390x Gerd Hoffmann
2009-10-19 19:34         ` [Qemu-devel] [PATCH 4/9] Add S390x virtio machine bus Gerd Hoffmann
2009-10-19 19:40           ` Alexander Graf
2009-10-19 20:10             ` Gerd Hoffmann
2009-10-20  8:36     ` [Qemu-devel] Re: [PATCH 2/9] Add KVM support for S390x Carsten Otte
2009-10-20  8:41       ` Alexander Graf
2009-10-20  8:02   ` [Qemu-devel] Re: [PATCH 1/9] Export function for VA defined ram allocation Carsten Otte
2009-10-19 19:24 ` [Qemu-devel] [PATCH 0/9] S390x KVM support Gerd Hoffmann
2009-10-19 19:32   ` Alexander Graf
2009-10-20  5:05 ` Avi Kivity
2009-10-20 16:40 ` [Qemu-devel] " Carsten Otte
2009-10-21  7:20   ` Alexander Graf
2009-10-21  7:24   ` Alexander Graf
2009-10-21  8:18     ` Carsten Otte
2009-10-21  8:23       ` Alexander Graf
2009-10-21  7:26   ` Alexander Graf
2009-10-22  9:08   ` Avi Kivity
2009-10-22  9:08     ` [Qemu-devel] " Avi Kivity
2009-10-22  9:11     ` Alexander Graf
2009-10-22  9:11       ` [Qemu-devel] " Alexander Graf
2009-10-22  9:53       ` Avi Kivity
2009-10-22  9:53         ` [Qemu-devel] " Avi Kivity
2009-10-22  9:55         ` Alexander Graf
2009-10-22  9:55           ` [Qemu-devel] " Alexander Graf
2009-10-22  9:58           ` Alexander Graf
2009-10-22  9:58             ` [Qemu-devel] " Alexander Graf
2009-10-22 10:03           ` Avi Kivity
2009-10-22 10:03             ` [Qemu-devel] " Avi Kivity
2009-10-22 10:13             ` Alexander Graf
2009-10-22 10:13               ` [Qemu-devel] " Alexander Graf
2009-10-22 10:22             ` Carsten Otte
2009-10-22 10:22               ` [Qemu-devel] " Carsten Otte
2009-10-22 10:28               ` Avi Kivity
2009-10-22 10:28                 ` [Qemu-devel] " Avi Kivity
2009-10-22 10:43                 ` Carsten Otte
2009-10-22 10:43                   ` [Qemu-devel] " Carsten Otte
2009-10-22 10:49                   ` Avi Kivity
2009-10-22 10:49                     ` [Qemu-devel] " Avi Kivity
2009-10-22 11:10                     ` Carsten Otte
2009-10-22 11:10                       ` [Qemu-devel] " Carsten Otte
2009-11-02 20:23                       ` Alexander Graf
2009-11-02 20:23                         ` [Qemu-devel] " Alexander Graf
2009-11-03  8:55                         ` Avi Kivity
2009-11-03  8:55                           ` [Qemu-devel] " Avi Kivity
2009-10-22  9:18     ` Carsten Otte
2009-10-22  9:18       ` [Qemu-devel] " Carsten Otte
2009-10-22 10:02       ` Avi Kivity
2009-10-22 10:02         ` [Qemu-devel] " Avi Kivity
2009-10-22 10:20         ` Carsten Otte
2009-10-22 10:20           ` [Qemu-devel] " Carsten Otte
2009-10-22 10:29           ` Avi Kivity
2009-10-22 10:29             ` [Qemu-devel] " Avi Kivity
2009-10-21  9:24 [Qemu-devel] [PATCH 0/9] S390x KVM support v2 Alexander Graf
2009-10-21  9:24 ` [Qemu-devel] [PATCH 1/9] Export function for VA defined ram allocation Alexander Graf
2009-10-21  9:24   ` [Qemu-devel] [PATCH 2/9] Add KVM support for S390x Alexander Graf
2009-10-21  9:25     ` [Qemu-devel] [PATCH 3/9] Add support for S390x system emulation Alexander Graf
2009-10-21  9:25       ` [Qemu-devel] [PATCH 4/9] Add S390x virtio machine bus Alexander Graf
2009-10-21  9:25         ` [Qemu-devel] [PATCH 5/9] Add S390x virtio machine description Alexander Graf
2009-10-21  9:25           ` [Qemu-devel] [PATCH 6/9] S390 GDB stub Alexander Graf
2009-10-21  9:25             ` [Qemu-devel] [PATCH 7/9] Implement early printk in virtio-console Alexander Graf
2009-10-21  9:25               ` [Qemu-devel] [PATCH 8/9] Set default console to virtio on S390x Alexander Graf
2009-10-21 19:16 [Qemu-devel] [PATCH 0/9] S390x KVM support v3 Alexander Graf
2009-10-21 19:16 ` [Qemu-devel] [PATCH 1/9] Add KVM support for S390x Alexander Graf
2009-10-21 19:16   ` [Qemu-devel] [PATCH 2/9] Allocate physical memory in low virtual address space Alexander Graf
2009-10-21 19:16     ` [Qemu-devel] [PATCH 3/9] Add support for S390x system emulation Alexander Graf
2009-10-21 19:16       ` [Qemu-devel] [PATCH 4/9] Add S390x virtio machine bus Alexander Graf
2009-10-21 19:16         ` [Qemu-devel] [PATCH 5/9] Add S390x virtio machine description Alexander Graf
2009-10-21 19:16           ` [Qemu-devel] [PATCH 6/9] S390 GDB stub Alexander Graf
2009-10-21 19:16             ` [Qemu-devel] [PATCH 7/9] Implement early printk in virtio-console Alexander Graf
2009-10-21 19:17               ` [Qemu-devel] [PATCH 8/9] Set default console to virtio on S390x Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1255963059-10298-9-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=cotte@de.ibm.com \
    --cc=hare@suse.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.