From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eero Nurkkala Subject: Re: [PATCH] OMAP: McBSP: Do not use extensive spin locks for dma_op_mode Date: Tue, 27 Oct 2009 13:07:23 +0200 Message-ID: <1256641643.30157.339.camel@eenurkka-desktop> References: <1256641215-26131-1-git-send-email-peter.ujfalusi@nokia.com> Reply-To: ext-eero.nurkkala@nokia.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1256641215-26131-1-git-send-email-peter.ujfalusi@nokia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: "Ujfalusi Peter (Nokia-D/Tampere)" Cc: "tony@atomide.com" , "alsa-devel@alsa-project.org" , "linux-omap@vger.kernel.org" , "Valentin Eduardo (Nokia-D/Helsinki)" , "broonie@opensource.wolfsonmicro.com" List-Id: linux-omap@vger.kernel.org On Tue, 2009-10-27 at 12:00 +0100, Ujfalusi Peter (Nokia-D/Tampere) wrote: > The use of the spin lock, which supposed to protect the the > dma_op_mode causing "INFO: inconsistent lock state" on > playback start. > Remove the spin locks around the dma_op_mode, when it's > purpuse is to protect the dma_op_mode. > > Signed-off-by: Peter Ujfalusi > --- You may wish to double read the message above, as it's quite confusing =) Otherwise, that spinlocking is highly unnecessary and things are far better without than with it. The only case it could be useful is in SMPs, but OMAPs are not such quite yet - and when they are, things will need to be re-though anyway. - Eero