From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dustin Kirkland Subject: Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network Date: Thu, 29 Oct 2009 09:43:37 -0500 Message-ID: <1256827417.25064.122.camel@x200> References: <1256807803.10825.39.camel@blaa> Reply-To: kirkland@canonical.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-BYfHdGioGl+iA3cgaAx8" Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, Anthony Liguori , Scott Tsai To: Mark McLoughlin Return-path: Received: from adelie.canonical.com ([91.189.90.139]:45603 "EHLO adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754246AbZJ2Onj (ORCPT ); Thu, 29 Oct 2009 10:43:39 -0400 In-Reply-To: <1256807803.10825.39.camel@blaa> Sender: kvm-owner@vger.kernel.org List-ID: --=-BYfHdGioGl+iA3cgaAx8 Content-Type: multipart/mixed; boundary="=-ibVYxTkSCH5khWGCobU9" --=-ibVYxTkSCH5khWGCobU9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2009-10-29 at 09:16 +0000, Mark McLoughlin wrote: > Hi Dustin, >=20 > On Wed, 2009-10-28 at 14:22 -0500, Dustin Kirkland wrote: > > I believe that we have identified a regression in qemu-kvm-0.11.0. >=20 > Regression versus which previous version of qemu-kvm? Okay, sorry for the ambiguity. I actually had to clarify this for myself. The regression is as compared to the kvm-84 package that the previous version of Ubuntu (9.04 Jaunty) carried. In this package, we carried the attached patch from Anthony Liguori. I had incorrectly assumed that this patch made it into the upstream tree. As Anthony stated in his earlier email, a different implementation of the fix from Rusty was committed instead. The fix as committed doesn't quite solve the problem as we're experiencing it. :-Dustin --=-ibVYxTkSCH5khWGCobU9 Content-Disposition: attachment; filename="virtio-net_disable_gso.patch" Content-Type: text/x-patch; name="virtio-net_disable_gso.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 V29yayBhcm91bmQgYnJva2VuIHZpcnRpbyBkcml2ZXJzIGluIDIuNi4yNg0KDQpTaWduZWQtb2Zm LWJ5OiBBbnRob255IExpZ3VvcmkgPGFsaWd1b3JpQHVzLmlibS5jb20+DQoNCmRpZmYgLS1naXQg YS9xZW11L2h3L3ZpcnRpby1uZXQuYyBiL3FlbXUvaHcvdmlydGlvLW5ldC5jDQppbmRleCA5YmNl M2EwLi41YjYxNWY5IDEwMDY0NA0KLS0tIGEvcWVtdS9ody92aXJ0aW8tbmV0LmMNCisrKyBiL3Fl bXUvaHcvdmlydGlvLW5ldC5jDQpAQCAtMTIwLDYgKzEyMCw5IEBAIHN0YXRpYyB1aW50MzJfdCB2 aXJ0aW9fbmV0X2dldF9mZWF0dXJlcyhWaXJ0SU9EZXZpY2UgKnZkZXYpDQogDQogICAgIGlmICh0 YXBfaGFzX3ZuZXRfaGRyKGhvc3QpKSB7DQogICAgICAgICB0YXBfdXNpbmdfdm5ldF9oZHIoaG9z dCwgMSk7DQorI2lmIDANCisgICAgICAgIC8qIFN0b3AgYWR2ZXJ0aXNpbmcgYWR2YW5jZWQgZmVh dHVyZXMgdW50aWwgd2Ugd29yayBhcm91bmQgdGhlIGZhY3QNCisgICAgICAgICAqIHRoYXQgdGhp cyBpcyB0b3RhbGx5IGJyb2tlbiBpbiAyLjYuMjYga2VybmVscyAqLw0KICAgICAgICAgZmVhdHVy ZXMgfD0gKDEgPDwgVklSVElPX05FVF9GX0NTVU0pOw0KICAgICAgICAgZmVhdHVyZXMgfD0gKDEg PDwgVklSVElPX05FVF9GX0dVRVNUX0NTVU0pOw0KICAgICAgICAgZmVhdHVyZXMgfD0gKDEgPDwg VklSVElPX05FVF9GX0dVRVNUX1RTTzQpOw0KQEAgLTEzMCw2ICsxMzMsNyBAQCBzdGF0aWMgdWlu dDMyX3QgdmlydGlvX25ldF9nZXRfZmVhdHVyZXMoVmlydElPRGV2aWNlICp2ZGV2KQ0KICAgICAg ICAgZmVhdHVyZXMgfD0gKDEgPDwgVklSVElPX05FVF9GX0hPU1RfRUNOKTsNCiAgICAgICAgIGZl YXR1cmVzIHw9ICgxIDw8IFZJUlRJT19ORVRfRl9NUkdfUlhCVUYpOw0KICAgICAgICAgLyogS2Vy bmVsIGNhbid0IGFjdHVhbGx5IGhhbmRsZSBVRk8gaW4gc29mdHdhcmUgY3VycmVudGx5LiAqLw0K KyNlbmRpZg0KICAgICB9DQogI2VuZGlmDQogDQpAQCAtMzc0LDggKzM3OCwxNCBAQCBzdGF0aWMg aW50IHJlY2VpdmVfaGVhZGVyKFZpcnRJT05ldCAqbiwgc3RydWN0IGlvdmVjICppb3YsIGludCBp b3ZjbnQsDQogICAgIHN0cnVjdCB2aXJ0aW9fbmV0X2hkciAqaGRyID0gaW92WzBdLmlvdl9iYXNl Ow0KICAgICBpbnQgb2Zmc2V0ID0gMDsNCiANCisjaWYgMA0KICAgICBoZHItPmZsYWdzID0gMDsN CiAgICAgaGRyLT5nc29fdHlwZSA9IFZJUlRJT19ORVRfSERSX0dTT19OT05FOw0KKyNlbHNlDQor ICAgIC8qIHdlIG5lZWQgdG8gY2xlYXIgb3V0IHRoZSB3aG9sZSBoZWFkZXIsIGluY2x1ZGluZyBh bnkgZ2FyYmFnZSB0aGF0IG1heSBiZQ0KKyAgICAgKi8NCisgICAgbWVtc2V0KGhkciwgMCwgc2l6 ZW9mKCpoZHIpKTsNCisjZW5kaWYNCiANCiAjaWZkZWYgVEFQX1ZORVRfSERSDQogICAgIGlmICh0 YXBfaGFzX3ZuZXRfaGRyKG4tPnZjLT52bGFuLT5maXJzdF9jbGllbnQpKSB7DQo= --=-ibVYxTkSCH5khWGCobU9-- --=-BYfHdGioGl+iA3cgaAx8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEABECAAYFAkrpqhkACgkQs7pNXIOmEZQA+ACfU9YQI1BBXXi/lIUYqz8ucG9+ JnkAnRsuNPlAzdWAnaN6vxRAoLdCw25Z =ltdM -----END PGP SIGNATURE----- --=-BYfHdGioGl+iA3cgaAx8-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N3WE4-0000jj-Ks for qemu-devel@nongnu.org; Thu, 29 Oct 2009 10:43:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N3WE4-0000jL-1g for qemu-devel@nongnu.org; Thu, 29 Oct 2009 10:43:44 -0400 Received: from [199.232.76.173] (port=44245 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N3WE3-0000jB-Mc for qemu-devel@nongnu.org; Thu, 29 Oct 2009 10:43:43 -0400 Received: from adelie.canonical.com ([91.189.90.139]:52191) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N3WE2-0007vb-PW for qemu-devel@nongnu.org; Thu, 29 Oct 2009 10:43:43 -0400 Subject: Re: [Qemu-devel] qemu-kvm-0.11 regression, crashes on older guests with virtio network From: Dustin Kirkland In-Reply-To: <1256807803.10825.39.camel@blaa> References: <1256807803.10825.39.camel@blaa> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-BYfHdGioGl+iA3cgaAx8" Date: Thu, 29 Oct 2009 09:43:37 -0500 Message-ID: <1256827417.25064.122.camel@x200> Mime-Version: 1.0 Reply-To: kirkland@canonical.com List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark McLoughlin Cc: Scott Tsai , qemu-devel@nongnu.org, kvm@vger.kernel.org --=-BYfHdGioGl+iA3cgaAx8 Content-Type: multipart/mixed; boundary="=-ibVYxTkSCH5khWGCobU9" --=-ibVYxTkSCH5khWGCobU9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2009-10-29 at 09:16 +0000, Mark McLoughlin wrote: > Hi Dustin, >=20 > On Wed, 2009-10-28 at 14:22 -0500, Dustin Kirkland wrote: > > I believe that we have identified a regression in qemu-kvm-0.11.0. >=20 > Regression versus which previous version of qemu-kvm? Okay, sorry for the ambiguity. I actually had to clarify this for myself. The regression is as compared to the kvm-84 package that the previous version of Ubuntu (9.04 Jaunty) carried. In this package, we carried the attached patch from Anthony Liguori. I had incorrectly assumed that this patch made it into the upstream tree. As Anthony stated in his earlier email, a different implementation of the fix from Rusty was committed instead. The fix as committed doesn't quite solve the problem as we're experiencing it. :-Dustin --=-ibVYxTkSCH5khWGCobU9 Content-Disposition: attachment; filename="virtio-net_disable_gso.patch" Content-Type: text/x-patch; name="virtio-net_disable_gso.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 V29yayBhcm91bmQgYnJva2VuIHZpcnRpbyBkcml2ZXJzIGluIDIuNi4yNg0KDQpTaWduZWQtb2Zm LWJ5OiBBbnRob255IExpZ3VvcmkgPGFsaWd1b3JpQHVzLmlibS5jb20+DQoNCmRpZmYgLS1naXQg YS9xZW11L2h3L3ZpcnRpby1uZXQuYyBiL3FlbXUvaHcvdmlydGlvLW5ldC5jDQppbmRleCA5YmNl M2EwLi41YjYxNWY5IDEwMDY0NA0KLS0tIGEvcWVtdS9ody92aXJ0aW8tbmV0LmMNCisrKyBiL3Fl bXUvaHcvdmlydGlvLW5ldC5jDQpAQCAtMTIwLDYgKzEyMCw5IEBAIHN0YXRpYyB1aW50MzJfdCB2 aXJ0aW9fbmV0X2dldF9mZWF0dXJlcyhWaXJ0SU9EZXZpY2UgKnZkZXYpDQogDQogICAgIGlmICh0 YXBfaGFzX3ZuZXRfaGRyKGhvc3QpKSB7DQogICAgICAgICB0YXBfdXNpbmdfdm5ldF9oZHIoaG9z dCwgMSk7DQorI2lmIDANCisgICAgICAgIC8qIFN0b3AgYWR2ZXJ0aXNpbmcgYWR2YW5jZWQgZmVh dHVyZXMgdW50aWwgd2Ugd29yayBhcm91bmQgdGhlIGZhY3QNCisgICAgICAgICAqIHRoYXQgdGhp cyBpcyB0b3RhbGx5IGJyb2tlbiBpbiAyLjYuMjYga2VybmVscyAqLw0KICAgICAgICAgZmVhdHVy ZXMgfD0gKDEgPDwgVklSVElPX05FVF9GX0NTVU0pOw0KICAgICAgICAgZmVhdHVyZXMgfD0gKDEg PDwgVklSVElPX05FVF9GX0dVRVNUX0NTVU0pOw0KICAgICAgICAgZmVhdHVyZXMgfD0gKDEgPDwg VklSVElPX05FVF9GX0dVRVNUX1RTTzQpOw0KQEAgLTEzMCw2ICsxMzMsNyBAQCBzdGF0aWMgdWlu dDMyX3QgdmlydGlvX25ldF9nZXRfZmVhdHVyZXMoVmlydElPRGV2aWNlICp2ZGV2KQ0KICAgICAg ICAgZmVhdHVyZXMgfD0gKDEgPDwgVklSVElPX05FVF9GX0hPU1RfRUNOKTsNCiAgICAgICAgIGZl YXR1cmVzIHw9ICgxIDw8IFZJUlRJT19ORVRfRl9NUkdfUlhCVUYpOw0KICAgICAgICAgLyogS2Vy bmVsIGNhbid0IGFjdHVhbGx5IGhhbmRsZSBVRk8gaW4gc29mdHdhcmUgY3VycmVudGx5LiAqLw0K KyNlbmRpZg0KICAgICB9DQogI2VuZGlmDQogDQpAQCAtMzc0LDggKzM3OCwxNCBAQCBzdGF0aWMg aW50IHJlY2VpdmVfaGVhZGVyKFZpcnRJT05ldCAqbiwgc3RydWN0IGlvdmVjICppb3YsIGludCBp b3ZjbnQsDQogICAgIHN0cnVjdCB2aXJ0aW9fbmV0X2hkciAqaGRyID0gaW92WzBdLmlvdl9iYXNl Ow0KICAgICBpbnQgb2Zmc2V0ID0gMDsNCiANCisjaWYgMA0KICAgICBoZHItPmZsYWdzID0gMDsN CiAgICAgaGRyLT5nc29fdHlwZSA9IFZJUlRJT19ORVRfSERSX0dTT19OT05FOw0KKyNlbHNlDQor ICAgIC8qIHdlIG5lZWQgdG8gY2xlYXIgb3V0IHRoZSB3aG9sZSBoZWFkZXIsIGluY2x1ZGluZyBh bnkgZ2FyYmFnZSB0aGF0IG1heSBiZQ0KKyAgICAgKi8NCisgICAgbWVtc2V0KGhkciwgMCwgc2l6 ZW9mKCpoZHIpKTsNCisjZW5kaWYNCiANCiAjaWZkZWYgVEFQX1ZORVRfSERSDQogICAgIGlmICh0 YXBfaGFzX3ZuZXRfaGRyKG4tPnZjLT52bGFuLT5maXJzdF9jbGllbnQpKSB7DQo= --=-ibVYxTkSCH5khWGCobU9-- --=-BYfHdGioGl+iA3cgaAx8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEABECAAYFAkrpqhkACgkQs7pNXIOmEZQA+ACfU9YQI1BBXXi/lIUYqz8ucG9+ JnkAnRsuNPlAzdWAnaN6vxRAoLdCw25Z =ltdM -----END PGP SIGNATURE----- --=-BYfHdGioGl+iA3cgaAx8--