All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxim Levitsky <maximlevitsky@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	"hostap@lists.shmoo.com" <hostap@lists.shmoo.com>
Subject: Re: [PATCH 2/2] nl80211: allow to authenticate to access point that we already authenticated
Date: Sat, 31 Oct 2009 11:36:29 +0200	[thread overview]
Message-ID: <1256981789.3089.0.camel@maxim-laptop> (raw)
In-Reply-To: <1256967840.3555.70.camel@johannes.local>

On Sat, 2009-10-31 at 06:44 +0100, Johannes Berg wrote: 
> On Fri, 2009-10-30 at 23:54 +0200, Maxim Levitsky wrote:
> > >From 02be2525b95ec3c57323dda1a9e0c6da3a9817e6 Mon Sep 17 00:00:00 2001
> > From: Maxim Levitsky <maximlevitsky@gmail.com>
> > Date: Fri, 30 Oct 2009 23:50:27 +0200
> > Subject: [PATCH 2/2] nl80211: allow to authenticate to access point that we already authenticated
> > 
> > This is permitted by standards, and used by driver_nl80211 of wpa_supplicant
> > Just start new authentication as if we weren't authenticated before
> 
> NACK. This leaks the auth request here and in mac80211, so we cannot do
> it this simply. Again though, the case you're running into should be
> fixed by that wpa_supplicant patch.

I was afraid of that... oh well thanks.

Best regards,
Maxim Levitsky

> 
> johannes
> 
> > ---
> >  net/wireless/mlme.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/net/wireless/mlme.c b/net/wireless/mlme.c
> > index 83c2a28..3d91b4e 100644
> > --- a/net/wireless/mlme.c
> > +++ b/net/wireless/mlme.c
> > @@ -372,7 +372,7 @@ int __cfg80211_mlme_auth(struct cfg80211_registered_device *rdev,
> >  		if (wdev->auth_bsses[i] &&
> >  		    memcmp(bssid, wdev->auth_bsses[i]->pub.bssid,
> >  						ETH_ALEN) == 0)
> > -			return -EALREADY;
> > +			wdev->auth_bsses[i] = NULL;
> >  	}
> >  
> >  	memset(&req, 0, sizeof(req));
> 



  reply	other threads:[~2009-10-31  9:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-30 21:49 [PATH 0/2] Make driver_nl80211 really work Maxim Levitsky
2009-10-30 21:52 ` [PATCH 1/2] Allow scanning while in authenticated only state Maxim Levitsky
2009-10-31  5:43   ` Johannes Berg
2009-10-31  9:46     ` Maxim Levitsky
2009-10-31 10:02       ` Johannes Berg
2009-10-31 10:33         ` Maxim Levitsky
2009-10-31 10:44           ` Johannes Berg
2009-11-01 20:10           ` Jouni Malinen
2009-11-02 23:17             ` Maxim Levitsky
2009-11-03  8:16               ` Johannes Berg
2009-10-30 21:54 ` [PATCH 2/2] nl80211: allow to authenticate to access point that we already authenticated Maxim Levitsky
2009-10-31  5:44   ` Johannes Berg
2009-10-31  9:36     ` Maxim Levitsky [this message]
2009-10-30 22:33 ` [PATH 0/2] Make driver_nl80211 really work Maxim Levitsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1256981789.3089.0.camel@maxim-laptop \
    --to=maximlevitsky@gmail.com \
    --cc=hostap@lists.shmoo.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.