Re: [PATCH] alsa-lib: snd_device_name_hint misbehaving

From: John Lindgren <john.lindgren@tds.net>
To: Jaroslav Kysela <perex@perex.cz>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] alsa-lib: snd_device_name_hint misbehaving
Date: Mon, 02 Nov 2009 13:12:21 -0500	[thread overview]
Message-ID: <1257185541.1937.17.camel@dark-knight> (raw)
In-Reply-To: <alpine.LNX.2.00.0911020718220.5500@eeebox2.perex-int.cz>

On Mon, 2009-11-02 at 07:21 +0100, Jaroslav Kysela wrote:
> On Sun, 1 Nov 2009, John Lindgren wrote:
> 
> > * Remove erroneous snd_config_delete calls that cause later calls to
> > snd_pcm_open to fail.
> 
> It does not look good. Have you checked with valgrind if there are no 
> memory leaks?

You're making the same mistake that the original author of the code
made.  snd_config_delete is not a call to free memory; it is a call to
remove sections of the loaded configuration.  The configuration nodes
that were being passed to snd_config_delete were returned by
snd_config_search, which returns direct pointers to the actual nodes in
the configuration.  It does no memory duplication.

> Please, split your changes to single patches. Thanks.

I will do so when I have the time to learn Git a little better.  (I
normally use Mercurial).

John Lindgren