From: Artem Bityutskiy <dedekind1@gmail.com>
To: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: add lock fixup for AT49BV640D and AT49BV640DT chips
Date: Tue, 03 Nov 2009 09:05:14 +0200 [thread overview]
Message-ID: <1257231914.21596.39.camel@localhost> (raw)
In-Reply-To: <1256817902-16534-1-git-send-email-hans-christian.egtvedt@atmel.com>
On Thu, 2009-10-29 at 13:05 +0100, Hans-Christian Egtvedt wrote:
> This patch sets the MTD_POWERUP_LOCK flag for AT49BV640D and AT49BV640DT
> devices, since the devices are locked when powered up and needs to be unlocked
> before interfaced.
>
> Quote datasheet; "At power-up and reset, all sectors have their Softlock
> protection mode enabled.".
>
> Tested on AVR32 hardware platform with an AT49BV640D flash device.
>
> Signed-off-by: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
> ---
> drivers/mtd/chips/cfi_cmdset_0001.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/chips/cfi_cmdset_0001.c b/drivers/mtd/chips/cfi_cmdset_0001.c
> index e7563a9..6228115 100644
> --- a/drivers/mtd/chips/cfi_cmdset_0001.c
> +++ b/drivers/mtd/chips/cfi_cmdset_0001.c
> @@ -52,6 +52,7 @@
> #define M50FLW080A 0x0080
> #define M50FLW080B 0x0081
> #define AT49BV640D 0x02de
> +#define AT49BV640DT 0x02db
>
> static int cfi_intelext_read (struct mtd_info *, loff_t, size_t, size_t *, u_char *);
> static int cfi_intelext_write_words(struct mtd_info *, loff_t, size_t, size_t *, const u_char *);
> @@ -255,6 +256,11 @@ static void fixup_use_point(struct mtd_info *mtd, void *param)
> }
> }
>
> +static void fixup_use_at49bv640dx_lock(struct mtd_info *mtd, void *param)
> +{
> + mtd->flags |= MTD_POWERUP_LOCK;
> +}
> +
> static void fixup_use_write_buffers(struct mtd_info *mtd, void *param)
> {
> struct map_info *map = mtd->priv;
> @@ -313,6 +319,8 @@ static struct cfi_fixup fixup_table[] = {
> * we know that is the case.
> */
> { CFI_MFR_ANY, CFI_ID_ANY, fixup_use_point, NULL },
> + { CFI_MFR_ATMEL, AT49BV640D, fixup_use_at49bv640dx_lock, NULL },
> + { CFI_MFR_ATMEL, AT49BV640DT, fixup_use_at49bv640dx_lock, NULL },
> { 0, 0, NULL, NULL }
> };
Why you add this to the fixup_table, not cfi_fixup_table?
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2009-11-03 7:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 12:05 [PATCH] mtd: add lock fixup for AT49BV640D and AT49BV640DT chips Hans-Christian Egtvedt
2009-11-03 7:05 ` Artem Bityutskiy [this message]
2009-11-03 7:44 ` Hans-Christian Egtvedt
2009-11-03 7:47 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257231914.21596.39.camel@localhost \
--to=dedekind1@gmail.com \
--cc=hans-christian.egtvedt@atmel.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.