From: "Michael Chan" <mchan@broadcom.com>
To: "Eric Dumazet" <eric.dumazet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"Linux Netdev List" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next-2.6] bnx2: avoid compiler warnings
Date: Tue, 3 Nov 2009 10:01:34 -0800 [thread overview]
Message-ID: <1257271294.8625.9.camel@HP1> (raw)
In-Reply-To: <4AEFF536.1020402@gmail.com>
On Tue, 2009-11-03 at 01:17 -0800, Eric Dumazet wrote:
> drivers/net/bnx2.c: In function ‘bnx2_enable_forced_2g5’:
> drivers/net/bnx2.c:1447: warning: ‘bmcr’ may be used uninitialized in this function
> drivers/net/bnx2.c: In function ‘bnx2_disable_forced_2g5’:
> drivers/net/bnx2.c:1482: warning: ‘bmcr’ may be used uninitialized in this function
>
> One fix would be to have an initial value, but a plain return might be better.
I agree that plain return is better. Thanks.
Acked-by: Michael Chan <mchan@broadcom.com>
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> ---
>
> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
> index 08cddb6..539d23b 100644
> --- a/drivers/net/bnx2.c
> +++ b/drivers/net/bnx2.c
> @@ -1466,6 +1466,8 @@ bnx2_enable_forced_2g5(struct bnx2 *bp)
> } else if (CHIP_NUM(bp) == CHIP_NUM_5708) {
> bnx2_read_phy(bp, bp->mii_bmcr, &bmcr);
> bmcr |= BCM5708S_BMCR_FORCE_2500;
> + } else {
> + return;
> }
>
> if (bp->autoneg & AUTONEG_SPEED) {
> @@ -1500,6 +1502,8 @@ bnx2_disable_forced_2g5(struct bnx2 *bp)
> } else if (CHIP_NUM(bp) == CHIP_NUM_5708) {
> bnx2_read_phy(bp, bp->mii_bmcr, &bmcr);
> bmcr &= ~BCM5708S_BMCR_FORCE_2500;
> + } else {
> + return;
> }
>
> if (bp->autoneg & AUTONEG_SPEED)
>
next prev parent reply other threads:[~2009-11-03 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 9:17 [PATCH net-next-2.6] bnx2: avoid compiler warnings Eric Dumazet
2009-11-03 18:01 ` Michael Chan [this message]
2009-11-04 13:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257271294.8625.9.camel@HP1 \
--to=mchan@broadcom.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.