Re: [PATCH 1/7] compat: add struct compat_ifreq etc to compat.h

From: Daniel Walker <dwalker@fifo99.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, David Miller <davem@davemloft.net>,
	Christoph Hellwig <hch@lst.de>,
	netdev@vger.kernel.org
Subject: Re: [PATCH 1/7] compat: add struct compat_ifreq etc to compat.h
Date: Fri, 06 Nov 2009 10:17:17 -0800	[thread overview]
Message-ID: <1257531437.7630.2.camel@c-dwalke-linux.qualcomm.com> (raw)
In-Reply-To: <1257530949-9695-2-git-send-email-arnd@arndb.de>

On Fri, 2009-11-06 at 19:09 +0100, Arnd Bergmann wrote:
> +struct compat_ifreq {
> +#define IFHWADDRLEN     6
> +#define IFNAMSIZ        16
> +        union {
> +                char    ifrn_name[IFNAMSIZ];            /* if name,
> e.g. "en0" */
> +        } ifr_ifrn;
> +        union {
> +                struct  sockaddr ifru_addr;
> +                struct  sockaddr ifru_dstaddr;
> +                struct  sockaddr ifru_broadaddr;
> +                struct  sockaddr ifru_netmask;
> +                struct  sockaddr ifru_hwaddr;
> +                short   ifru_flags;
> +                compat_int_t     ifru_ivalue;
> +                compat_int_t     ifru_mtu;
> +                struct  compat_ifmap ifru_map;
> +                char    ifru_slave[IFNAMSIZ];   /* Just fits the size
> */
> +               char    ifru_newname[IFNAMSIZ];
> +                compat_caddr_t ifru_data;
> +           /* XXXX? ifru_settings should be here */
> +        } ifr_ifru;
> +};
> +

Did you just copy this from someplace else? Many of the lines seems to
be tab damaged.

Daniel