All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, devel@linuxdriverproject.org,
	mcgrof@gmail.com, "Luis R. Rodriguez" <lrodriguez@atheros.com>
Subject: [PATCH 21/29] ath5k: remove double cache alignment, ath_rxbuf_alloc() already does it
Date: Sat,  7 Nov 2009 15:18:58 -0500	[thread overview]
Message-ID: <1257625146-17971-22-git-send-email-lrodriguez@atheros.com> (raw)
In-Reply-To: <1257625146-17971-1-git-send-email-lrodriguez@atheros.com>

ath5k is using the (csz - 1) twice as ath_rxbuf_alloc() already allocates
and moves skb->data accordingly. Remove the extra (csz -1).

Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
 drivers/net/wireless/ath/ath5k/base.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index 31d556a..c7fc13c 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -1185,12 +1185,12 @@ struct sk_buff *ath5k_rx_skb_alloc(struct ath5k_softc *sc, dma_addr_t *skb_addr)
 	 * fake physical layer header at the start.
 	 */
 	skb = ath_rxbuf_alloc(common,
-			      common->rx_bufsize + common->cachelsz - 1,
+			      common->rx_bufsize,
 			      GFP_ATOMIC);
 
 	if (!skb) {
 		ATH5K_ERR(sc, "can't alloc skbuff of size %u\n",
-				common->rx_bufsize + common->cachelsz - 1);
+				common->rx_bufsize);
 		return NULL;
 	}
 
-- 
1.6.5.2.143.g8cc62


  parent reply	other threads:[~2009-11-07 20:19 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-07 20:18 [PATCH 00/29] ath: virtual wiphy updates / add ath9k_common Luis R. Rodriguez
2009-11-07 20:18 ` [PATCH 01/29] ath9k: fix listening to idle requests Luis R. Rodriguez
2009-11-07 20:18 ` [PATCH 02/29] ath9k: update hw configuration for virtual wiphys Luis R. Rodriguez
2009-11-07 20:18 ` [PATCH 03/29] ath9k: simpify RX by calling ath_get_virt_hw() once Luis R. Rodriguez
2009-11-07 20:18 ` [PATCH 04/29] ath9k: use the passed ieee80211_hw on ath_rx_prepare() Luis R. Rodriguez
2009-11-07 20:18 ` [PATCH 05/29] ath9k: pass the ieee80211_hw on radio enable/disable Luis R. Rodriguez
2009-11-07 20:18 ` [PATCH 06/29] ath9k: use correct hw for tx aggregation TX completion Luis R. Rodriguez
2009-11-08 16:00   ` Jouni Malinen
2009-11-08 19:11     ` Luis R. Rodriguez
2009-11-07 20:18 ` [PATCH 07/29] ath9k: use the right hw on ath_tx_setup_buffer() for HT Luis R. Rodriguez
2009-11-07 20:18 ` [PATCH 08/29] ath9k: handle low buffer space for virtual wiphys Luis R. Rodriguez
2009-11-07 20:18 ` [PATCH 09/29] ath9k: do not pass the entire descriptor to ath_rx_prepare() Luis R. Rodriguez
2009-11-07 20:18 ` [PATCH 10/29] ath9k_hw: move ath_extend_tsf() to hw code to share as ath9k_hw_extend_tsf() Luis R. Rodriguez
2009-11-07 20:18 ` [PATCH 11/29] ath9k: move struct ath_ani to common area Luis R. Rodriguez
2009-11-07 20:18 ` [PATCH 12/29] ath9k: use the ieee80211_hw to get to an sband on ath_rx_prepare() Luis R. Rodriguez
2009-11-07 20:18 ` [PATCH 13/29] ath9k: move RX check code into helper ath9k_rx_accept() Luis R. Rodriguez
2009-11-07 20:18 ` [PATCH 14/29] ath9k: remove temp variable ratecode from ath_rx_prepare() Luis R. Rodriguez
2009-11-07 20:18 ` [PATCH 15/29] ath9k: move rate descriptor reading into a helper Luis R. Rodriguez
2009-11-07 20:18 ` [PATCH 16/29] ath9k: move qual processing " Luis R. Rodriguez
2009-11-07 20:18 ` [PATCH 17/29] ath9k: move rssi " Luis R. Rodriguez
2009-11-07 20:18 ` [PATCH 18/29] ath9k: avoid the copy skb->cb on every RX'd skb Luis R. Rodriguez
2009-11-07 20:18 ` [PATCH 19/29] ath9k: move the rx_stats->rs_datalen check to ath9k_rx_accept() Luis R. Rodriguez
2009-11-07 20:18 ` [PATCH 20/29] ath: move the rx bufsize to common to share with ath5k/ath9k Luis R. Rodriguez
2009-11-07 20:18 ` Luis R. Rodriguez [this message]
2009-11-07 20:18 ` [PATCH 22/29] ath9k: move the max rx buffer size check to ath9k_rx_accept() Luis R. Rodriguez
2009-11-07 20:19 ` [PATCH 23/29] ath9k: rename ath_rx_prepare() to ath9k_rx_skb_preprocess() Luis R. Rodriguez
2009-11-07 20:19 ` [PATCH 24/29] ath9k: move driver keymap, keymax and splitmic to common Luis R. Rodriguez
2009-11-07 20:19 ` [PATCH 25/29] ath5k: use the common->keymap Luis R. Rodriguez
2009-11-07 20:19 ` [PATCH 26/29] ath9k: move RX skb post processing to a helper Luis R. Rodriguez
2009-11-07 20:19 ` [PATCH 27/29] ath9k_common: add new module to share 802.11n driver helpers Luis R. Rodriguez
2009-11-07 20:19 ` [PATCH 28/29] ath9k_common: remove ath9k_compute_qual() Luis R. Rodriguez
2009-11-07 20:19 ` [PATCH 29/29] ath9k_common: clarify and correct jumbogram processing Luis R. Rodriguez
2009-11-07 20:23 ` [PATCH 00/29] ath: virtual wiphy updates / add ath9k_common Luis R. Rodriguez
2009-11-07 20:25 ` Luis R. Rodriguez
2009-11-08 21:22   ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1257625146-17971-22-git-send-email-lrodriguez@atheros.com \
    --to=lrodriguez@atheros.com \
    --cc=devel@linuxdriverproject.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mcgrof@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.