On Sat, 2009-11-07 at 20:44 -0500, Devin Heitmueller wrote:
> On Sat, Nov 7, 2009 at 8:37 PM, Andy Walls <awalls@radix.net> wrote:
> > On Sat, 2009-11-07 at 21:47 +0000, Ben Hutchings wrote:
> >> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> >> ---
> >> I'm not really sure whether it's better to do this in the drivers which
> >> specify which firmware file to use, or just once in the xc2028 tuner
> >> driver.  Your call.
> >>
> >> Ben.
> >
> > Ben,
> >
> > I would suspect it's better left in the xc2028 tuner driver module.
> >
> > Rationale:
> >
> > a. it will be consistent with other modules like the cx25840 module.
> > ivtv and cx23885 load the cx25840 module yet the MODULE_FIRMWARE
> > advertisement for the CX2584[0123] or CX2388[578] A/V core firmware is
> > in the cx25840 module.
> >
> > b. not every ivtv or cx18 supported TV card, for example, needs the
> > XCeive tuner chip firmware, so it's not a strict requirement for those
> > modules.  It is a strict(-er) requirement for the xc2028 module.
> >
> > My $0.02
> >
> > Regards,
> > Andy
> 
> It's not clear to me what this MODULE_FIRMWARE is going to be used
> for, but if it's for some sort of module dependency system, then it
> definitely should *not* be a dependency for em28xx.  There are lots of
> em28xx based devices that do not use the xc3028, and those users
> should not be expected to go out and find/extract the firmware for
> some tuner they don't have.

This information is currently used by initramfs builders to find
required firmware files.  I also use this information in the Debian
kernel upgrade script to warn if a currently loaded driver may require
firmware in the new kernel version and the firmware is not installed.
This is important during the transition of various drivers from built-in
to separate firmware.

Neither of these uses applies to TV tuners, but the information may
still be useful in installers.

> Also, how does this approach handle the situation where there are two
> different possible firmwares depending on the card using the firmware.
>  As in the example above, you the xc3028 can require either the xc3028
> or xc3028L firmware depending on the board they have.  Does this
> change now result in both firmware images being required?

It really depends on how the information is used.  Given that there are
many drivers that load different firmware files for different devices
(or even support multiple different versions with different names), it
would be rather stupid to treat these declaration as requirements.

Ben.

-- 
Ben Hutchings
The generation of random numbers is too important to be left to chance.
                                                            - Robert Coveyou