Re: [PATCH V2] ASoC - Add support for upto 16 channels on OMAP MCBSP

[Liam Girdwood <lrg@slimlogic.co.uk>]

On Sat, 2009-11-07 at 22:11 +0200, Grazvydas Ignotas wrote:
> On Fri, Nov 6, 2009 at 8:24 PM, Jarkko Nikula <jhnikula@gmail.com> wrote:
> > On Thu, 05 Nov 2009 21:00:08 +0000
> > Liam Girdwood <lrg@slimlogic.co.uk> wrote:
> >
> >> From: Graeme Gregory <gg@slimlogic.co.uk>
> >>
> >> This patch increases the number of supported audio channels from 4
> >> to 16 and has been sponsored by Shotspotter Inc. It also fixes a
> >> FSYNC rate calculation bug when McBSP is FSYNC master.
> >>
> > I would not call it as bug but more like an implementation
> > restriction :-)
> >
> > But as the patch now requires that machine driver using OMAP as a
> > master must provide the sample rate generator input clock frequency, I
> > would like to hear how it will work on Pandora.
> >
> > Grazvydas: are you able to test is the Pandora still playing after applying
> > patch [1] to omap-mcbsp.c and my patch below to omap3pandora.c?
> >
> > I made an assumption that input clock frequency on Pandora is
> > 8 * 32 * sample_rate.
> 
> Seems to be working fine, tried playing several different sample rates
> and also recording path. FYI pandora has TWL4030 256FS clock connected
> to OMAP's CLKS pin.
> 
> Tested-by: Grazvydas Ignotas <notasas@gmail.com>

Jarkko, Peter,

Any chance we could have your Ack before applying.

Thanks

Liam