From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter P Waskiewicz Jr Subject: Re: RFC: ethtool support for n-tuple filter programming Date: Sun, 08 Nov 2009 22:54:18 -0800 Message-ID: <1257749659.2609.6.camel@ppwaskie-mobl2> References: <1257533841.2610.12.camel@ppwaskie-mobl2> <20091107.202712.222562359.davem@davemloft.net> <1257745762.2609.5.camel@ppwaskie-mobl2> <20091108.223848.234795788.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" To: David Miller Return-path: Received: from mga01.intel.com ([192.55.52.88]:50289 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751690AbZKIGyO (ORCPT ); Mon, 9 Nov 2009 01:54:14 -0500 In-Reply-To: <20091108.223848.234795788.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, 2009-11-08 at 23:38 -0700, David Miller wrote: > From: Peter P Waskiewicz Jr > Date: Sun, 08 Nov 2009 21:49:21 -0800 > > > On Sat, 2009-11-07 at 21:27 -0700, David Miller wrote: > >> From: Peter P Waskiewicz Jr > >> Date: Fri, 06 Nov 2009 10:57:21 -0800 > >> > >> > Any comments, thoughts, suggestions, or ideas are welcome. > >> > >> We can use the existing datastructures and defines used for > >> ETHTOOL_GRX* for new ethtool commands that do filtering. > >> > >> NIU can filter on these tuples too. > > > > Are you suggesting to extend the flow hash stuff that is already in > > ethtool (same ioctl)? If so, that makes sense. I'll go ahead and get > > some patches together for review. > > Not exactly. > > Rather, I'm saying to use a new ethtool command, but make use of the > existing flow hash datastructures as much as possible. Ah ok. Makes even more sense. Thanks David. -PJ