Re: [PATCH -v5 08/11] tracing: not trace mips_timecounter_init() in MIPS

From: Wu Zhangjin <wuzhangjin@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ralf Baechle <ralf@linux-mips.org>,
	Nicholas Mc Guire <der.herr@hofr.at>,
	Richard Sandiford <rdsandiford@googlemail.com>,
	David Daney <ddaney@caviumnetworks.com>,
	Adam Nemet <anemet@caviumnetworks.com>,
	Patrik Kluba <kpajko79@gmail.com>
Subject: Re: [PATCH -v5 08/11] tracing: not trace mips_timecounter_init() in MIPS
Date: Mon, 09 Nov 2009 22:35:20 +0800	[thread overview]
Message-ID: <1257777320.3451.132.camel@falcon.domain.org> (raw)
In-Reply-To: <1257771288.2845.11.camel@frodo>

Hi,

On Mon, 2009-11-09 at 07:54 -0500, Steven Rostedt wrote:
[...]
> 
> Just do it in the Makefile. We can add __arch_notrace, and then in the
> Makefile define it with the arch.
> 
> ifeq ($(ARCH), MIPS)
> 	CFLAGS_foo.o = -D__arch_notrace=notrace
> endif
> 
> And we can simply define __arch_notrace in a header:
> 
> #ifndef __arch_notrace
> # define __arch_notrace
> #endif
> 
> I much rather uglify the Makefile than the code. 
> 

Seems can not totally avoid the problem mentioned by Frederic, that is
if there are two many functions in the file, and different platforms
care about different functions ;) 

what about Frederic's __time, just replace that __arch_notrace by
__time_notrace, and only consider the time relative functions currently?
Seems this will really make the stuff simpler.

Regards,
	Wu Zhangjin