From: Huang Ying <ying.huang@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: [BUGFIX -v2 for .32] crypto, gcm, fix another complete call in complete fuction
Date: Tue, 10 Nov 2009 10:49:59 +0800 [thread overview]
Message-ID: <1257821399.22519.2410.camel@yhuang-dev.sh.intel.com> (raw)
In-Reply-To: <20091109190250.GC9588@gondor.apana.org.au>
On Tue, 2009-11-10 at 03:02 +0800, Herbert Xu wrote:
> On Mon, Nov 09, 2009 at 03:24:14PM +0800, Huang Ying wrote:
> > The flow of the complete function (xxx_done) in gcm.c is as follow:
>
> Thanks the patch looks pretty good overall.
>
> > -static void gcm_hash_final_done(struct crypto_async_request *areq,
> > - int err)
> > +static void __gcm_hash_final_done(struct aead_request *req,
> > + struct crypto_gcm_req_priv_ctx *pctx,
> > + int err)
>
> Just one nit though, do we really need to carry this pctx around
> everywhere? It seems to me that it's always crypto_gcm_reqctx(req),
> no?
Yes. This is for performance only. Because crypto_gcm_reqctx(req) is not
so trivial (it needs access tfm), and used by every xxx_done function,
so I think it is better to just call crypto_gcm_reqctx once and pass it
down. Do you think so?
Best Regards,
Huang Ying
next prev parent reply other threads:[~2009-11-10 2:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 7:24 [BUGFIX -v2 for .32] crypto, gcm, fix another complete call in complete fuction Huang Ying
2009-11-09 19:02 ` Herbert Xu
2009-11-10 2:49 ` Huang Ying [this message]
2009-11-10 3:10 ` Herbert Xu
2009-11-10 4:20 ` Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257821399.22519.2410.camel@yhuang-dev.sh.intel.com \
--to=ying.huang@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.