All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Walls <awalls@radix.net>
To: Devin Heitmueller <dheitmueller@kernellabs.com>
Cc: ivtv-devel@ivtvdriver.org, linux-media@vger.kernel.org
Subject: Re: cx18: Reprise of YUV frame alignment improvements
Date: Tue, 24 Nov 2009 18:39:33 -0500	[thread overview]
Message-ID: <1259105973.3069.14.camel@palomino.walls.org> (raw)
In-Reply-To: <829197380911240957t5bc93f3esb85bea7a5a12bf04@mail.gmail.com>

On Tue, 2009-11-24 at 12:57 -0500, Devin Heitmueller wrote:
> On Mon, Nov 23, 2009 at 8:49 PM, Andy Walls <awalls@radix.net> wrote:
> > Of course that's all speculation about the problem.  If you could
> > reproduce the condition and then
> >
> > # echo 271 > /sys/modules/cx18/parameters/debug
> 
> Hi Andy,
> 
> Thanks for the additional info.  I had to tear down my HVR-1600 test
> rig to finish the em28xx PAL support

So I read -- Looks good!

>  (using a PVR-350 and the CD of
> PAL VBI samples you were very kind in sending me), but I should be
> able to get back to this early next week.

Take your time.  I've got plenty of other problems. ;)


BTW, I did a quick skim of your cx18-alsa stuff.  I noticed two things:

1.  A memory leak in an error path:

http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2/rev/cb267593943f#l85


2.  Technically open_id should probably be changed to an atomic type and
atomic_inc() used:

http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2/rev/cb267593943f#l80

Under normal use it will likely never matter though, but perhaps someone
could use it as a possible exploit.



I'll try and give the code a good review and test sometime this weekend.
I just wanted to let you know about those minor bugs before I forgot.

Regards,
Andy

> Devin



  reply	other threads:[~2009-11-24 23:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-11  4:31 cx18: Reprise of YUV frame alignment improvements Andy Walls
2009-11-12  0:38 ` Brandon Jenkins
2009-11-12  1:06   ` Andy Walls
2009-11-12  1:23     ` Brandon Jenkins
2009-11-23  3:04 ` Devin Heitmueller
2009-11-23 12:12   ` Andy Walls
2009-11-23 12:32     ` Andy Walls
2009-11-23 17:09     ` Devin Heitmueller
2009-11-24  1:49       ` Andy Walls
2009-11-24 17:57         ` Devin Heitmueller
2009-11-24 23:39           ` Andy Walls [this message]
2009-11-25 16:43             ` Devin Heitmueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1259105973.3069.14.camel@palomino.walls.org \
    --to=awalls@radix.net \
    --cc=dheitmueller@kernellabs.com \
    --cc=ivtv-devel@ivtvdriver.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.