All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhu Yi <yi.zhu@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [RFC 1/2] wireless: add ieee80211_asmdu_to_8023s
Date: Fri, 27 Nov 2009 09:06:54 +0800	[thread overview]
Message-ID: <1259284014.13126.111.camel@debian> (raw)
In-Reply-To: <1259228968.32372.40.camel@johannes.local>

On Thu, 2009-11-26 at 17:49 +0800, Johannes Berg wrote:
> > +     skb->dev = dev;
> > +     skb_queue_head_init(&frame_list);
> 
> ^ use __ versions please, no need for locking since it's on stack

You are right. Good catch!

> > +     dev->stats.rx_packets++;
> > +     dev->stats.rx_bytes += skb->len;
> 
> Shouldn't rx_packets be per sub-frame? 

Not very sure. Maybe it's one frame from the device's perspective? The
original code does this so I didn't change the behavior. Should I?

Thanks,
-yi


  reply	other threads:[~2009-11-27  1:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-26  6:03 [RFC 1/2] wireless: add ieee80211_asmdu_to_8023s Zhu Yi
2009-11-26  6:03 ` [RFC 2/2] iwmc3200wifi: rx aggregation support Zhu Yi
2009-11-26  9:49 ` [RFC 1/2] wireless: add ieee80211_asmdu_to_8023s Johannes Berg
2009-11-27  1:06   ` Zhu Yi [this message]
2009-11-27  9:18     ` Johannes Berg
2009-11-26 10:05 ` Johannes Berg
2009-11-27  2:52   ` Zhu Yi
2009-11-27  9:20     ` Johannes Berg
2009-11-27  9:30       ` Zhu Yi
2009-11-27  9:33         ` Johannes Berg
2009-11-27  9:35           ` Johannes Berg
2009-11-30  2:34         ` Zhu Yi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1259284014.13126.111.camel@debian \
    --to=yi.zhu@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.