From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3CBCC433E3 for ; Fri, 24 Jul 2020 04:34:03 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB419206F0 for ; Fri, 24 Jul 2020 04:34:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB419206F0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jypOi-000495-Fj; Fri, 24 Jul 2020 04:33:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jypOh-000490-U6 for xen-devel@lists.xenproject.org; Fri, 24 Jul 2020 04:33:27 +0000 X-Inumbo-ID: d10b65d4-cd66-11ea-a36e-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d10b65d4-cd66-11ea-a36e-12813bfff9fa; Fri, 24 Jul 2020 04:33:27 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9DF10ACA3; Fri, 24 Jul 2020 04:33:34 +0000 (UTC) Subject: Re: [PATCH v3 0/8] x86: compat header generation and checking adjustments To: Jan Beulich , "xen-devel@lists.xenproject.org" References: From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <125c9611-dcae-f119-b44b-e3333b5dc0fd@suse.com> Date: Fri, 24 Jul 2020 06:33:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Julien Grall , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 23.07.20 17:45, Jan Beulich wrote: > As was pointed out by 0e2e54966af5 ("mm: fix public declaration of > struct xen_mem_acquire_resource"), we're not currently handling structs > correctly that have uint64_aligned_t fields. Patch 2 demonstrates that > there was also an issue with XEN_GUEST_HANDLE_64(). > > 1: x86: fix compat header generation > 2: x86/mce: add compat struct checking for XEN_MC_inject_v2 > 3: x86/mce: bring hypercall subop compat checking in sync again > 4: x86/dmop: add compat struct checking for XEN_DMOP_map_mem_type_to_ioreq_server > 5: evtchn: add compat struct checking for newer sub-ops > 6: x86: generalize padding field handling > 7: flask: drop dead compat translation code > 8: x86: only generate compat headers actually needed > > v3: Build fix for old gcc in patch 1. New patch 5. Just an idea: Instead of parsing an existing header and trying to create a compat header from it, assuming some special constructs and names, wouldn't it make more sense to have a common input file and create non-compat and compat headers (and the functions/macros to convert them into each other) from it? This would at once drop the need for compat checking and new interfaces could be tested automatically to not require a compat variant. Juergen