From: Joe Perches <joe@perches.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, macro@linux-mips.org,
davem@davemloft.net
Subject: Re: [PATCH] drivers/net/defxx.c: use %pMF to show MAC address
Date: Thu, 07 Jan 2010 17:39:10 -0800 [thread overview]
Message-ID: <1262914750.10429.88.camel@Joe-Laptop.home> (raw)
In-Reply-To: <201001071624.20139.hartleys@visionengravers.com>
On Thu, 2010-01-07 at 16:24 -0700, H Hartley Sweeten wrote:
> Use the %pMF kernel extension to display the MAC address.
> The address will still be displayed in the FDDI Canonical format.
> diff --git a/drivers/net/defxx.c b/drivers/net/defxx.c
> index 6a6ea03..e4eac4b 100644
> --- a/drivers/net/defxx.c
> +++ b/drivers/net/defxx.c
> @@ -1052,12 +1052,9 @@ static int __devinit dfx_driver_init(struct net_device *dev,
> board_name = "DEFEA";
> if (dfx_bus_pci)
> board_name = "DEFPA";
> - pr_info("%s: %s at %saddr = 0x%llx, IRQ = %d, "
> - "Hardware addr = %02X-%02X-%02X-%02X-%02X-%02X\n",
> + pr_info("%s: %s at %saddr = 0x%llx, IRQ = %d, Hardware addr = %pMF\n",
> print_name, board_name, dfx_use_mmio ? "" : "I/O ",
I believe the output will _now_ be in the canonical form.
Before it wasn't bit reversed. Now it should be.
next prev parent reply other threads:[~2010-01-08 1:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 23:24 [PATCH] drivers/net/defxx.c: use %pMF to show MAC address H Hartley Sweeten
2010-01-08 0:58 ` David Miller
2010-01-08 1:39 ` Joe Perches [this message]
2010-01-08 2:06 ` Maciej W. Rozycki
2010-01-08 2:11 ` H Hartley Sweeten
2010-01-08 7:47 ` David Miller
2010-01-08 13:34 ` Maciej W. Rozycki
2010-01-08 17:54 ` Joe Perches
2010-01-08 18:58 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262914750.10429.88.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.