Re: vdr: questions regarding cplusplus.patch

[Paul Menzel <paulepanter@users.sourceforge.net>]

[-- Attachment #1: Type: text/plain, Size: 1845 bytes --]

Am Sonntag, den 10.01.2010, 13:39 +0100 schrieb Henning Heinold:
> On Sun, Jan 10, 2010 at 08:53:18AM +0100, Paul Menzel wrote:
> > packaging VDR for OE you added cplusplus.patch [1] to be applied. I am
> > trying to get the patches upstream, but I have some questions.
> > 
> > Is it correct, that the two changes have the following goals?
> > 
> > 1. Instead of using the C headers which are deprecated use the headers
> > provided by C++ as mentioned for example in [2].
> > 2. You changed `canonicalize_file_name(FileName);` to
> > `realpath(FileName,NULL);`. Is that because OE just support Linux and
> > not GNU/Hurd for example [3]?
> > 3. I do not understand why a lot of headers are included in tools.h and
> > tools.c. But I have to look that up in some reference.
>
> with gcc 4.x and 4.4 c++ is stricter at including headers the right way.
> So you need to include a couple of headers, because some functions
> are not found. You can test it in oe with using binutils 2.20 and
> gcc-4.4.2 and leave the patches out.
> 
> The problem with canonicalize_file_name was, that the function too
> wasn't found with gcc-4.4.2. So I googled and found that
> canonicalize_file_name(FileName) is the same as realpath(FileName,NULL),
> but realpath was found.
> 
> I hope this clears some stuff.

Dear Henning,


thank your for your explanation.

I tried to reproduce that on my Debian Sid/unstable system with

        $ g++ --version
        g++ (Debian 4.4.2-8) 4.4.2
        $ ld --version # binutils 2.20-4
        GNU ld (GNU Binutils for Debian) 2.20
        $ git clone git://git.gekrumbel.de/vdr.git
        $ cd vdr
        $ make

and did not get any warnings.

I will try to reproduce this in OE but have to read up on how to change
the versions in my `local.conf`.


Thanks,

Paul

[-- Attachment #2: Dies ist ein digital signierter Nachrichtenteil --]
[-- Type: application/pgp-signature, Size: 205 bytes --]