From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 09/22] drm/i915: Switch to use HWS indices rather than addresses Date: Mon, 18 Mar 2019 13:21:17 +0000 Message-ID: <12636f1d-1af5-5b5f-db2c-e16d257a38c8@linux.intel.com> References: <20190318095204.9913-1-chris@chris-wilson.co.uk> <20190318095204.9913-9-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7004E89612 for ; Mon, 18 Mar 2019 13:21:19 +0000 (UTC) In-Reply-To: <20190318095204.9913-9-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE4LzAzLzIwMTkgMDk6NTEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJZiB3ZSB1c2UgdGhl IFNUT1JFX0RBVEFfSU5ERVggZnVuY3Rpb24gd2UgY2FuIHVzZSBhIGZpeGVkIG9mZnNldCBhbmQK PiBhdm9pZCBoYXZpbmcgdG8gbG9va3VwIHVwIHRoZSBlbmdpbmUgSFdTIGFkZHJlc3MuIEEgc3Rl cCBjbG9zZXIgdG8gYmVpbmcKPiBhYmxlIHRvIGVtaXQgdGhlIGZpbmFsIGJyZWFkY3J1bWIgZHVy aW5nIHJlcXVlc3RfYWRkIHJhdGhlciB0aGFuIGxhdGVyCj4gaW4gdGhlIHN1Ym1pc3Npb24gaW50 ZXJydXB0IGhhbmRsZXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0Bj aHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9n dWNfc3VibWlzc2lvbi5jIHwgIDMgKystCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9s cmMuYyAgICAgICAgICAgIHwgMTcgKysrKysrKy0tLS0tLS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYyAgICAgfCAxNiArKysrKystLS0tLS0tLS0tCj4gICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmggICAgIHwgIDQgKystLQo+ICAg NCBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAyMyBkZWxldGlvbnMoLSkKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX3N1Ym1pc3Npb24uYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19zdWJtaXNzaW9uLmMKPiBpbmRleCA0YTU3 MjcyMzM0MTkuLmM0YWQ3Mzk4MDk4OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9ndWNfc3VibWlzc2lvbi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZ3VjX3N1Ym1pc3Npb24uYwo+IEBAIC01ODMsNyArNTgzLDggQEAgc3RhdGljIHZvaWQgaW5q ZWN0X3ByZWVtcHRfY29udGV4dChzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCj4gICAJCX0gZWxz ZSB7Cj4gICAJCQljcyA9IGdlbjhfZW1pdF9nZ3R0X3dyaXRlKGNzLAo+ICAgCQkJCQkJICBHVUNf UFJFRU1QVF9GSU5JU0hFRCwKPiAtCQkJCQkJICBhZGRyKTsKPiArCQkJCQkJICBhZGRyLAo+ICsJ CQkJCQkgIDApOwo+ICAgCQkJKmNzKysgPSBNSV9OT09QOwo+ICAgCQkJKmNzKysgPSBNSV9OT09Q Owo+ICAgCQl9Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiBpbmRleCBmYmY2NzEwNWYwNDAu LjdlMGMyMGEyZDczMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9s cmMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gQEAgLTE3Mywx MiArMTczLDYgQEAgc3RhdGljIHZvaWQgZXhlY2xpc3RzX2luaXRfcmVnX3N0YXRlKHUzMiAqcmVn X3N0YXRlLAo+ICAgCQkJCSAgICAgc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLAo+ICAg CQkJCSAgICAgc3RydWN0IGludGVsX3JpbmcgKnJpbmcpOwo+ICAgCj4gLXN0YXRpYyBpbmxpbmUg dTMyIGludGVsX2h3c19oYW5nY2hlY2tfYWRkcmVzcyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpl bmdpbmUpCj4gLXsKPiAtCXJldHVybiAoaTkxNV9nZ3R0X29mZnNldChlbmdpbmUtPnN0YXR1c19w YWdlLnZtYSkgKwo+IC0JCUk5MTVfR0VNX0hXU19IQU5HQ0hFQ0tfQUREUik7Cj4gLX0KPiAtCj4g ICBzdGF0aWMgaW5saW5lIHN0cnVjdCBpOTE1X3ByaW9saXN0ICp0b19wcmlvbGlzdChzdHJ1Y3Qg cmJfbm9kZSAqcmIpCj4gICB7Cj4gICAJcmV0dXJuIHJiX2VudHJ5KHJiLCBzdHJ1Y3QgaTkxNV9w cmlvbGlzdCwgbm9kZSk7Cj4gQEAgLTIyMTMsMTEgKzIyMDcsMTQgQEAgc3RhdGljIHUzMiAqZ2Vu OF9lbWl0X2ZpbmlfYnJlYWRjcnVtYihzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpyZXF1ZXN0LCB1MzIg KmNzKQo+ICAgewo+ICAgCWNzID0gZ2VuOF9lbWl0X2dndHRfd3JpdGUoY3MsCj4gICAJCQkJICBy ZXF1ZXN0LT5mZW5jZS5zZXFubywKPiAtCQkJCSAgcmVxdWVzdC0+dGltZWxpbmUtPmh3c3Bfb2Zm c2V0KTsKPiArCQkJCSAgcmVxdWVzdC0+dGltZWxpbmUtPmh3c3Bfb2Zmc2V0LAo+ICsJCQkJICAw KTsKPiAgIAo+ICAgCWNzID0gZ2VuOF9lbWl0X2dndHRfd3JpdGUoY3MsCj4gICAJCQkJICBpbnRl bF9lbmdpbmVfbmV4dF9oYW5nY2hlY2tfc2Vxbm8ocmVxdWVzdC0+ZW5naW5lKSwKPiAtCQkJCSAg aW50ZWxfaHdzX2hhbmdjaGVja19hZGRyZXNzKHJlcXVlc3QtPmVuZ2luZSkpOwo+ICsJCQkJICBJ OTE1X0dFTV9IV1NfSEFOR0NIRUNLX0FERFIsCj4gKwkJCQkgIE1JX0ZMVVNIX0RXX1NUT1JFX0lO REVYKTsKPiArCj4gICAKPiAgIAkqY3MrKyA9IE1JX1VTRVJfSU5URVJSVVBUOwo+ICAgCSpjcysr ID0gTUlfQVJCX09OX09GRiB8IE1JX0FSQl9FTkFCTEU7Cj4gQEAgLTIyNDEsOCArMjIzOCw4IEBA IHN0YXRpYyB1MzIgKmdlbjhfZW1pdF9maW5pX2JyZWFkY3J1bWJfcmNzKHN0cnVjdCBpOTE1X3Jl cXVlc3QgKnJlcXVlc3QsIHUzMiAqY3MpCj4gICAKPiAgIAljcyA9IGdlbjhfZW1pdF9nZ3R0X3dy aXRlX3JjcyhjcywKPiAgIAkJCQkgICAgICBpbnRlbF9lbmdpbmVfbmV4dF9oYW5nY2hlY2tfc2Vx bm8ocmVxdWVzdC0+ZW5naW5lKSwKPiAtCQkJCSAgICAgIGludGVsX2h3c19oYW5nY2hlY2tfYWRk cmVzcyhyZXF1ZXN0LT5lbmdpbmUpLAo+IC0JCQkJICAgICAgMCk7Cj4gKwkJCQkgICAgICBJOTE1 X0dFTV9IV1NfSEFOR0NIRUNLX0FERFIsCj4gKwkJCQkgICAgICBQSVBFX0NPTlRST0xfU1RPUkVf REFUQV9JTkRFWCk7Cj4gICAKPiAgIAkqY3MrKyA9IE1JX1VTRVJfSU5URVJSVVBUOwo+ICAgCSpj cysrID0gTUlfQVJCX09OX09GRiB8IE1JX0FSQl9FTkFCTEU7Cj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3JpbmdidWZmZXIuYwo+IGluZGV4IDM1ZmRlYmQ2N2U1Zi4uMDMxMGQ1ZDUzYmY5IDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+IEBAIC00MywxMiAr NDMsNiBAQAo+ICAgICovCj4gICAjZGVmaW5lIExFR0FDWV9SRVFVRVNUX1NJWkUgMjAwCj4gICAK PiAtc3RhdGljIGlubGluZSB1MzIgaHdzX2hhbmdjaGVja19hZGRyZXNzKHN0cnVjdCBpbnRlbF9l bmdpbmVfY3MgKmVuZ2luZSkKPiAtewo+IC0JcmV0dXJuIChpOTE1X2dndHRfb2Zmc2V0KGVuZ2lu ZS0+c3RhdHVzX3BhZ2Uudm1hKSArCj4gLQkJSTkxNV9HRU1fSFdTX0hBTkdDSEVDS19BRERSKTsK PiAtfQo+IC0KPiAgIHVuc2lnbmVkIGludCBpbnRlbF9yaW5nX3VwZGF0ZV9zcGFjZShzdHJ1Y3Qg aW50ZWxfcmluZyAqcmluZykKPiAgIHsKPiAgIAl1bnNpZ25lZCBpbnQgc3BhY2U7Cj4gQEAgLTMx Nyw4ICszMTEsOCBAQCBzdGF0aWMgdTMyICpnZW42X3Jjc19lbWl0X2JyZWFkY3J1bWIoc3RydWN0 IGk5MTVfcmVxdWVzdCAqcnEsIHUzMiAqY3MpCj4gICAJKmNzKysgPSBycS0+ZmVuY2Uuc2Vxbm87 Cj4gICAKPiAgIAkqY3MrKyA9IEdGWF9PUF9QSVBFX0NPTlRST0woNCk7Cj4gLQkqY3MrKyA9IFBJ UEVfQ09OVFJPTF9RV19XUklURTsKPiAtCSpjcysrID0gaHdzX2hhbmdjaGVja19hZGRyZXNzKHJx LT5lbmdpbmUpIHwgUElQRV9DT05UUk9MX0dMT0JBTF9HVFQ7Cj4gKwkqY3MrKyA9IFBJUEVfQ09O VFJPTF9RV19XUklURSB8IFBJUEVfQ09OVFJPTF9TVE9SRV9EQVRBX0lOREVYOwo+ICsJKmNzKysg PSBJOTE1X0dFTV9IV1NfSEFOR0NIRUNLX0FERFIgfCBQSVBFX0NPTlRST0xfR0xPQkFMX0dUVDsK PiAgIAkqY3MrKyA9IGludGVsX2VuZ2luZV9uZXh0X2hhbmdjaGVja19zZXFubyhycS0+ZW5naW5l KTsKPiAgIAo+ICAgCSpjcysrID0gTUlfVVNFUl9JTlRFUlJVUFQ7Cj4gQEAgLTQyMyw4ICs0MTcs MTAgQEAgc3RhdGljIHUzMiAqZ2VuN19yY3NfZW1pdF9icmVhZGNydW1iKHN0cnVjdCBpOTE1X3Jl cXVlc3QgKnJxLCB1MzIgKmNzKQo+ICAgCSpjcysrID0gcnEtPmZlbmNlLnNlcW5vOwo+ICAgCj4g ICAJKmNzKysgPSBHRlhfT1BfUElQRV9DT05UUk9MKDQpOwo+IC0JKmNzKysgPSBQSVBFX0NPTlRS T0xfUVdfV1JJVEUgfCBQSVBFX0NPTlRST0xfR0xPQkFMX0dUVF9JVkI7Cj4gLQkqY3MrKyA9IGh3 c19oYW5nY2hlY2tfYWRkcmVzcyhycS0+ZW5naW5lKTsKPiArCSpjcysrID0gKFBJUEVfQ09OVFJP TF9RV19XUklURSB8Cj4gKwkJIFBJUEVfQ09OVFJPTF9TVE9SRV9EQVRBX0lOREVYIHwKPiArCQkg UElQRV9DT05UUk9MX0dMT0JBTF9HVFRfSVZCKTsKPiArCSpjcysrID0gSTkxNV9HRU1fSFdTX0hB TkdDSEVDS19BRERSOwo+ICAgCSpjcysrID0gaW50ZWxfZW5naW5lX25leHRfaGFuZ2NoZWNrX3Nl cW5vKHJxLT5lbmdpbmUpOwo+ICAgCj4gICAJKmNzKysgPSBNSV9VU0VSX0lOVEVSUlVQVDsKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gaW5kZXggYTU3NDg5ZmNiMzAy Li5hMDJjOTJkYWM1ZGEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cmluZ2J1ZmZlci5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZl ci5oCj4gQEAgLTQxOSwxNCArNDE5LDE0IEBAIGdlbjhfZW1pdF9nZ3R0X3dyaXRlX3Jjcyh1MzIg KmNzLCB1MzIgdmFsdWUsIHUzMiBndHRfb2Zmc2V0LCB1MzIgZmxhZ3MpCj4gICB9Cj4gICAKPiAg IHN0YXRpYyBpbmxpbmUgdTMyICoKPiAtZ2VuOF9lbWl0X2dndHRfd3JpdGUodTMyICpjcywgdTMy IHZhbHVlLCB1MzIgZ3R0X29mZnNldCkKPiArZ2VuOF9lbWl0X2dndHRfd3JpdGUodTMyICpjcywg dTMyIHZhbHVlLCB1MzIgZ3R0X29mZnNldCwgdTMyIGZsYWdzKQo+ICAgewo+ICAgCS8qIHcvYTog Yml0IDUgbmVlZHMgdG8gYmUgemVybyBmb3IgTUlfRkxVU0hfRFcgYWRkcmVzcy4gKi8KPiAgIAlH RU1fQlVHX09OKGd0dF9vZmZzZXQgJiAoMSA8PCA1KSk7Cj4gICAJLyogT2Zmc2V0IHNob3VsZCBi ZSBhbGlnbmVkIHRvIDggYnl0ZXMgZm9yIGJvdGggKFFXL0RXKSB3cml0ZSB0eXBlcyAqLwo+ICAg CUdFTV9CVUdfT04oIUlTX0FMSUdORUQoZ3R0X29mZnNldCwgOCkpOwo+ICAgCj4gLQkqY3MrKyA9 IChNSV9GTFVTSF9EVyArIDEpIHwgTUlfRkxVU0hfRFdfT1BfU1RPUkVEVzsKPiArCSpjcysrID0g KE1JX0ZMVVNIX0RXICsgMSkgfCBNSV9GTFVTSF9EV19PUF9TVE9SRURXIHwgZmxhZ3M7Cj4gICAJ KmNzKysgPSBndHRfb2Zmc2V0IHwgTUlfRkxVU0hfRFdfVVNFX0dUVDsKPiAgIAkqY3MrKyA9IDA7 Cj4gICAJKmNzKysgPSB2YWx1ZTsKPiAKClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZy dGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=