From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753391Ab0AWUlh (ORCPT ); Sat, 23 Jan 2010 15:41:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752979Ab0AWUl1 (ORCPT ); Sat, 23 Jan 2010 15:41:27 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:50511 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751449Ab0AWUfx (ORCPT ); Sat, 23 Jan 2010 15:35:53 -0500 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Greg KH Cc: linux-kernel@vger.kernel.org, Russell King , Ben Dooks , Arnaud Patard , Krzysztof Helt , Andrew Morton , Antonino Daplas , Vincent Sanders Subject: [PATCH 19/29] move s3c241xfb's probe function to .devinit.text Date: Sat, 23 Jan 2010 21:35:27 +0100 Message-Id: <1264278937-19675-19-git-send-email-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 1.6.6 In-Reply-To: <1264189758-7197-1-git-send-email-u.kleine-koenig@pengutronix.de> References: <1264189758-7197-1-git-send-email-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pointers to s3c2410fb_probe and s3c2412fb_probe are passed to the core via platform_driver_register and so the functions must not disappear when the .init sections are discarded. Otherwise (if also having HOTPLUG=y) unbinding and binding a device to one of the drivers via sysfs will result in an oops as does a device being registered late. An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver. Signed-off-by: Uwe Kleine-König Cc: Russell King Cc: Ben Dooks Cc: Arnaud Patard Cc: Krzysztof Helt Cc: Andrew Morton Cc: Antonino Daplas Cc: Vincent Sanders --- drivers/video/s3c2410fb.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/s3c2410fb.c b/drivers/video/s3c2410fb.c index aac6612..2b094de 100644 --- a/drivers/video/s3c2410fb.c +++ b/drivers/video/s3c2410fb.c @@ -1004,12 +1004,12 @@ dealloc_fb: return ret; } -static int __init s3c2410fb_probe(struct platform_device *pdev) +static int __devinit s3c2410fb_probe(struct platform_device *pdev) { return s3c24xxfb_probe(pdev, DRV_S3C2410); } -static int __init s3c2412fb_probe(struct platform_device *pdev) +static int __devinit s3c2412fb_probe(struct platform_device *pdev) { return s3c24xxfb_probe(pdev, DRV_S3C2412); } -- 1.6.6