From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752331Ab0AWUgW (ORCPT ); Sat, 23 Jan 2010 15:36:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752121Ab0AWUgJ (ORCPT ); Sat, 23 Jan 2010 15:36:09 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:50549 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751229Ab0AWUf5 (ORCPT ); Sat, 23 Jan 2010 15:35:57 -0500 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Greg KH Cc: linux-kernel@vger.kernel.org, Dmitry Baryshkov , Russell King , Andrew Morton Subject: [PATCH 23/29] move sharpsl-pm's probe function to .devinit.text Date: Sat, 23 Jan 2010 21:35:31 +0100 Message-Id: <1264278937-19675-23-git-send-email-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 1.6.6 In-Reply-To: <1264189758-7197-1-git-send-email-u.kleine-koenig@pengutronix.de> References: <1264189758-7197-1-git-send-email-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A pointer to sharpsl_pm_probe is passed to the core via platform_driver_register and so the function must not disappear when the .init sections are discarded. Otherwise (if also having HOTPLUG=y) unbinding and binding a device to the driver via sysfs will result in an oops as does a device being registered late. An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver. Signed-off-by: Uwe Kleine-König Cc: Dmitry Baryshkov Cc: Russell King Acked-by: Eric Miao Cc: Andrew Morton --- arch/arm/mach-pxa/sharpsl_pm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-pxa/sharpsl_pm.c b/arch/arm/mach-pxa/sharpsl_pm.c index 67229a1..463d874 100644 --- a/arch/arm/mach-pxa/sharpsl_pm.c +++ b/arch/arm/mach-pxa/sharpsl_pm.c @@ -900,7 +900,7 @@ static struct platform_suspend_ops sharpsl_pm_ops = { }; #endif -static int __init sharpsl_pm_probe(struct platform_device *pdev) +static int __devinit sharpsl_pm_probe(struct platform_device *pdev) { int ret; -- 1.6.6