All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Blundell <philb@gnu.org>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH 12/12] task-base.bb: use uniform test for set
Date: Thu, 11 Feb 2010 13:04:13 +0000	[thread overview]
Message-ID: <1265893453.3777.1053.camel@mill.internal.reciva.com> (raw)
In-Reply-To: <1265663673-16312-13-git-send-email-rep.dot.nop@gmail.com>

On Mon, 2010-02-08 at 22:14 +0100, Bernhard Reutner-Fischer wrote: 
> -    if not hasattr(__builtins__, 'set'):
> +    try:
> +	set
> +    except NameError:
>  	from sets import Set as set

It's not completely obvious to me that this patch is an improvement: it
replaces a single line of code with three new ones and doesn't seem to
change the outcome.  Maybe one of our Python überhackers can comment on
whether or not this is really better.

p.





  reply	other threads:[~2010-02-11 13:06 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-08 21:14 [PATCH 0/12] random misc trivia Bernhard Reutner-Fischer
2010-02-08 21:14 ` [PATCH 01/12] trim superfluous trailing whitespace Bernhard Reutner-Fischer
2010-02-08 21:14   ` [PATCH 02/12] some more !getopt_long fixes Bernhard Reutner-Fischer
2010-02-08 21:14     ` [PATCH 03/12] osso-application-installer: nonworking Bernhard Reutner-Fischer
2010-02-08 21:14       ` [PATCH 04/12] matchbox-panel-2: fix DEPENDS Bernhard Reutner-Fischer
2010-02-08 21:14         ` [PATCH 05/12] no need to set LD nowadays Bernhard Reutner-Fischer
2010-02-08 21:14           ` [PATCH 06/12] quilt: use builtin date routines Bernhard Reutner-Fischer
2010-02-08 21:14             ` [PATCH 07/12] Document proxy setup in local.conf.sample Bernhard Reutner-Fischer
2010-02-08 21:14               ` [PATCH 08/12] commentary typo fix Bernhard Reutner-Fischer
2010-02-08 21:14                 ` [PATCH 09/12] flex: remove version specifics from generic inc Bernhard Reutner-Fischer
2010-02-08 21:14                   ` [PATCH 10/12] git: " Bernhard Reutner-Fischer
2010-02-08 21:14                     ` [PATCH 11/12] fix binutils patch to apply to 2.20 Bernhard Reutner-Fischer
2010-02-08 21:14                       ` [PATCH 12/12] task-base.bb: use uniform test for set Bernhard Reutner-Fischer
2010-02-11 13:04                         ` Phil Blundell [this message]
2010-02-11 21:57                           ` Khem Raj
2010-02-09 11:49                   ` [PATCH 09/12] flex: remove version specifics from generic inc Phil Blundell
2010-02-11  9:04               ` [PATCH 07/12] Document proxy setup in local.conf.sample Denys Dmytriyenko
2010-02-13 12:08                 ` Bernhard Reutner-Fischer
2010-02-15 20:14                   ` Denys Dmytriyenko
2010-02-09 11:06             ` [PATCH 06/12] quilt: use builtin date routines Phil Blundell
2010-02-08 21:56           ` [PATCH 05/12] no need to set LD nowadays Phil Blundell
2010-02-09  8:50             ` Bernhard Reutner-Fischer
2010-02-09  8:56               ` Phil Blundell
2010-02-10 16:48                 ` Bernhard Reutner-Fischer
2010-02-09  8:10           ` Koen Kooi
2010-02-09 11:58         ` [PATCH 04/12] matchbox-panel-2: fix DEPENDS Phil Blundell
2010-02-10 16:51           ` Bernhard Reutner-Fischer
2010-02-10 21:11       ` [PATCH 03/12] osso-application-installer: nonworking Bernhard Reutner-Fischer
2010-02-09  9:38     ` [PATCH 02/12] some more !getopt_long fixes Jens Seidel
2010-02-10  8:54       ` Bernhard Reutner-Fischer
2010-02-09 12:05   ` [PATCH 01/12] trim superfluous trailing whitespace Phil Blundell
2010-02-10 22:48   ` [PATCH 00/12] misc trivia Bernhard Reutner-Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1265893453.3777.1053.camel@mill.internal.reciva.com \
    --to=philb@gnu.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.