From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751540AbcFXVM2 (ORCPT ); Fri, 24 Jun 2016 17:12:28 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:59165 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751355AbcFXVM0 (ORCPT ); Fri, 24 Jun 2016 17:12:26 -0400 From: Arnd Bergmann To: y2038@lists.linaro.org Cc: Deepa Dinamani , "Theodore Ts'o" , Artem Bityutskiy , Linux Kernel Mailing List , Adrian Hunter , linux-mtd , Alexander Viro , Linux FS-devel Mailing List , Thomas Gleixner , Linus Torvalds Subject: Re: [Y2038] [PATCH v2 07/24] fs: ubifs: Replace CURRENT_TIME_SEC with current_time Date: Fri, 24 Jun 2016 23:14:06 +0200 Message-ID: <12663159.PWXCHjMIS1@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <1466382443-11063-1-git-send-email-deepa.kernel@gmail.com> <5694616.oYyysJP9uD@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:BZsONQ0hBNCjXy7QI0SB94vmp8I36zBaGg/qkU70GpxP8PDborC zb1+1GTJpcJWJmy/TZtKSTV4G2i90anNFMrUqZlY0tkAm9H4UzOS1pWc+GMVgx9xCQ5hnHM QAOF3fY6rZQn3PxvVq2JwkdrzbIuaex3AApAsZ4EB+4AhBDdM5bSPuVUVgYanYgNg78A2bs y9HrBeUYmuX7Ev0FiZiDw== X-UI-Out-Filterresults: notjunk:1;V01:K0:WSWjGsxuAfA=:qLqlOYNgX2lcczr9HgFlPX AiSAZen3anknFa8xlUU6amv6nFI/MTI7SIRpltF0MhrCFqxZeQxK20Hp3ygUl0Ovbegw6jrQ5 6P7ZPZuhRMk7XCL0l6OAbAeDu5hyaw0lSA4PXbBL5k/8j3vuyQIjrR990G+wehZgywPywP8fO dtW6D0R9kipQHMnhzcuHoptXSiNBVlAf+i/cqAXoJjjg4jbfSTT080Fb5bmBuiFG9t+kZ+Jsz BSnsqImFqDvy62sISrEB1tOrOmq440hc8v9jRm+6WJ8JfqUcLzHSi7gV7lFFR/DKN4mhPGulM VaWA1aYzanOpTacnAtg+6ogXn8kVNwtCcFGDTBnQEkt8B1KE5wynX1NG62IGr8kzfvuZfCMhg 7CMp1tX9YgsVqFaczcFfiMmMcsHd9qyEeFZsDpubzKEqrvA39FP6sdINq+zHuP0VrABBdOEss jYCP60PC9k8TM26cSOyoCBoKR7LLjr8DESxtSjKjBX5xnHVaZZtypkfNPYNNCuHv+zUTwb0Hz da0fJf4uqGdysR85p0ZH3biIy9wpNfRWHcjtsHNXMR8xJPiqfi8qJpdhs6KPUsrgM5bhkwKQf v1TfQslW343OcsFYDKKnwuCDG2omuW8Q5Osq6ELoUtfGNTpw66pYpdsK0UCy0gsp0AsQwDXTu 893y0J9w7SjB/n8nIzCEs6rzLPfRcqXccoRhPM2mu8m1StRw6EQn85v0RdqgdEnFRdMNMBofW JWie1LA4H7BvM1fD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, June 24, 2016 2:05:11 PM CEST Deepa Dinamani wrote: > > This part of the patch seems independent of the rest, as you don't actually > > use current_time() here, or assign the timespec to an inode. > > > > I'd suggest either leaving this part out of the patch series for now, > > or making it a separate patch that uses timespec64 directly. > > This is actually the root inode which is created and written to disk. > We actually want to use current_time() here, but this is not cached. > So we don't have a vfs inode. > > struct ubifs_ino_node represents inode format on the disk. > I thought it would be odd to fill this with timespec64 only here. > My plan was to switch it over to timespec64 when all of ubifs changes > to use timespec64. It is a bit odd, but I can't think of why that would be a problem. All the other instances have to wait until the inode timestamps are converted but this one does not. > This also was helping the current series as it let me delete > CURRENT_TIME macros. > I can add a comment to suggest this in code. > > But, what you suggest should also work fine since the on disk > representation is big enough to use timespec64 already. > Let me know if you want me to drop this change for now as we delete > CURRENT_TIME macros after rc1 now. I'd leave it in. Arnd