All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: Benoit PAPILLAULT <benoit.papillault@free.fr>,
	Johannes Berg <johannes@sipsolutions.net>,
	John Linville <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v3] mac80211: deprecate RX status noise
Date: Wed, 17 Feb 2010 17:51:58 -0500	[thread overview]
Message-ID: <1266447118.12365.21.camel@mj> (raw)
In-Reply-To: <43e72e891002171429j7f47c86bqd4374bf07b8979de@mail.gmail.com>

On Wed, 2010-02-17 at 14:29 -0800, Luis R. Rodriguez wrote:

> > Being per packet or global, I'm not an RF engineer to say what's best, but
> > even if it is global, "last_noise" would still be useful as "global noise
> > when the last packets was received from this node".
> 
> If anything it should be per center freq.

The noise value will be missed.  It's useful to see the signal to noise
ratio.  I have little trust to the absolute noise values, but I know
that the connection is bad if signal is just 3 dBm above the noise
measured by the same card with the same antenna on the same channel. 

Maybe it would be better to remove per-packet noise only when the "next
generation noise" is implemented?  It could be a batch of patches.

-- 
Regards,
Pavel Roskin

  reply	other threads:[~2010-02-17 22:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-17 20:05 [PATCH] mac80211: deprecate RX status noise Johannes Berg
2010-02-17 20:22 ` [PATCH v2] " Johannes Berg
2010-02-17 20:27   ` [PATCH v3] " Johannes Berg
2010-02-17 20:48     ` Benoit PAPILLAULT
2010-02-17 22:29       ` Luis R. Rodriguez
2010-02-17 22:51         ` Pavel Roskin [this message]
2010-02-18 12:07           ` Johannes Berg
2010-02-18 14:41             ` Holger Schurig
2010-02-18 14:48               ` Johannes Berg
2010-02-18 19:57                 ` Kalle Valo
2010-02-18 20:27                   ` Luis R. Rodriguez
     [not found]             ` <7f9d9abf1002181728q63c9f090je175681bc520f0ad@mail.gmail.com>
2010-02-20 11:06               ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1266447118.12365.21.camel@mj \
    --to=proski@gnu.org \
    --cc=benoit.papillault@free.fr \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mcgrof@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.