All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: "\"Oleg A. Arkhangelsky\"" <sysoleg@yandex.ru>
Cc: netdev@vger.kernel.org
Subject: Re: [net-next-2.6 PATCH] Preserve queue mapping with bonding and VLAN devices
Date: Tue, 23 Feb 2010 15:59:01 +0000	[thread overview]
Message-ID: <1266940741.2109.7.camel@achroite.uk.solarflarecom.com> (raw)
In-Reply-To: <33081266938239@webmail48.yandex.ru>

On Tue, 2010-02-23 at 18:17 +0300, "Oleg A. Arkhangelsky" wrote:
> 
> Must be applied with "[net-next-2.6 PATCH] Multiqueue support for bonding devices"
> 
> Forwarded packet goes more that once throught dev_queue_xmit() when
> using bonding or 802.1q VLAN devices, so we've lost rx-tx queue mapping
> index for real devices.
[...]

The queue mapping will normally be the same, only no longer biased by 1.
So I think a better solution would be to maintain that bias on TX as
well, or to remove the bias and reserve -1 for unknown RX queue.

We already have hardware that can do RSS across up to 128 RX queues, so
an 8-bit limit is uncomfortably close.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


  reply	other threads:[~2010-02-23 15:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-23 15:17 [net-next-2.6 PATCH] Preserve queue mapping with bonding and VLAN devices "Oleg A. Arkhangelsky"
2010-02-23 15:59 ` Ben Hutchings [this message]
2010-02-23 19:36   ` "Oleg A. Arkhangelsky"
2010-02-24  9:53     ` Jeff Kirsher
2010-02-26 13:50     ` David Miller
2010-02-27  9:53       ` "Oleg A. Arkhangelsky"
2010-02-27 10:02         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1266940741.2109.7.camel@achroite.uk.solarflarecom.com \
    --to=bhutchings@solarflare.com \
    --cc=netdev@vger.kernel.org \
    --cc=sysoleg@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.