From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754329Ab0CWI4K (ORCPT ); Tue, 23 Mar 2010 04:56:10 -0400 Received: from rcsinet12.oracle.com ([148.87.113.124]:23070 "EHLO rcsinet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753100Ab0CWI4I (ORCPT ); Tue, 23 Mar 2010 04:56:08 -0400 From: Yinghai Lu To: Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , David Miller , Benjamin Herrenschmidt , Linus Torvalds Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Ian Campbell , Yinghai Lu , Peter Zijlstra , Ingo Molnar Subject: [PATCH 1/4] x86: do not free zero sized per cpu areas Date: Tue, 23 Mar 2010 01:39:44 -0700 Message-Id: <1269333587-1866-2-git-send-email-yinghai@kernel.org> X-Mailer: git-send-email 1.6.4.2 In-Reply-To: <1269333587-1866-1-git-send-email-yinghai@kernel.org> References: <1269333587-1866-1-git-send-email-yinghai@kernel.org> X-Source-IP: acsmt355.oracle.com [141.146.40.155] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090205.4BA87EF4.018C,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ian Campbell This avoids an infinite loop in free_early_partial(). Add a warning to free_early_partial to catch future problems. -v5: put back start > end back into WARN_ONCE() -v6: use one line for if according to linus Signed-off-by: Ian Campbell Signed-off-by: Yinghai Lu Cc: Peter Zijlstra Cc: Ingo Molnar --- kernel/early_res.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/kernel/early_res.c b/kernel/early_res.c index 3cb2c66..69bed5b 100644 --- a/kernel/early_res.c +++ b/kernel/early_res.c @@ -333,6 +333,12 @@ void __init free_early_partial(u64 start, u64 end) struct early_res *r; int i; + if (start == end) + return; + + if (WARN_ONCE(start > end, "free_early_partial: wrong range [%#llx, %#llx]\n", start, end)) + return; + try_next: i = find_overlapped_early(start, end); if (i >= max_early_res) -- 1.6.4.2 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yinghai Lu Subject: [PATCH 1/4] x86: do not free zero sized per cpu areas Date: Tue, 23 Mar 2010 01:39:44 -0700 Message-ID: <1269333587-1866-2-git-send-email-yinghai@kernel.org> References: <1269333587-1866-1-git-send-email-yinghai@kernel.org> Return-path: Received: from rcsinet12.oracle.com ([148.87.113.124]:23070 "EHLO rcsinet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753100Ab0CWI4I (ORCPT ); Tue, 23 Mar 2010 04:56:08 -0400 In-Reply-To: <1269333587-1866-1-git-send-email-yinghai@kernel.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , David Miller , Be Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Ian Campbell , Yinghai Lu , Peter Zijlstra , Ingo Molnar From: Ian Campbell This avoids an infinite loop in free_early_partial(). Add a warning to free_early_partial to catch future problems. -v5: put back start > end back into WARN_ONCE() -v6: use one line for if according to linus Signed-off-by: Ian Campbell Signed-off-by: Yinghai Lu Cc: Peter Zijlstra Cc: Ingo Molnar --- kernel/early_res.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/kernel/early_res.c b/kernel/early_res.c index 3cb2c66..69bed5b 100644 --- a/kernel/early_res.c +++ b/kernel/early_res.c @@ -333,6 +333,12 @@ void __init free_early_partial(u64 start, u64 end) struct early_res *r; int i; + if (start == end) + return; + + if (WARN_ONCE(start > end, "free_early_partial: wrong range [%#llx, %#llx]\n", start, end)) + return; + try_next: i = find_overlapped_early(start, end); if (i >= max_early_res) -- 1.6.4.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcsinet12.oracle.com ([148.87.113.124]:23070 "EHLO rcsinet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753100Ab0CWI4I (ORCPT ); Tue, 23 Mar 2010 04:56:08 -0400 From: Yinghai Lu Subject: [PATCH 1/4] x86: do not free zero sized per cpu areas Date: Tue, 23 Mar 2010 01:39:44 -0700 Message-ID: <1269333587-1866-2-git-send-email-yinghai@kernel.org> In-Reply-To: <1269333587-1866-1-git-send-email-yinghai@kernel.org> References: <1269333587-1866-1-git-send-email-yinghai@kernel.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , David Miller , Benjamin Herrenschmidt , Linus Torvalds Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Ian Campbell , Yinghai Lu , Peter Zijlstra Message-ID: <20100323083944.2S5gOgW9I0IgwtFWkifDpY0XMuTWdxJ7M5cuvSxkmNQ@z> From: Ian Campbell This avoids an infinite loop in free_early_partial(). Add a warning to free_early_partial to catch future problems. -v5: put back start > end back into WARN_ONCE() -v6: use one line for if according to linus Signed-off-by: Ian Campbell Signed-off-by: Yinghai Lu Cc: Peter Zijlstra Cc: Ingo Molnar --- kernel/early_res.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/kernel/early_res.c b/kernel/early_res.c index 3cb2c66..69bed5b 100644 --- a/kernel/early_res.c +++ b/kernel/early_res.c @@ -333,6 +333,12 @@ void __init free_early_partial(u64 start, u64 end) struct early_res *r; int i; + if (start == end) + return; + + if (WARN_ONCE(start > end, "free_early_partial: wrong range [%#llx, %#llx]\n", start, end)) + return; + try_next: i = find_overlapped_early(start, end); if (i >= max_early_res) -- 1.6.4.2