From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755789Ab0C3GVB (ORCPT ); Tue, 30 Mar 2010 02:21:01 -0400 Received: from mail-bw0-f209.google.com ([209.85.218.209]:34946 "EHLO mail-bw0-f209.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755638Ab0C3GUR (ORCPT ); Tue, 30 Mar 2010 02:20:17 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=IdFfJHGWQreRH9jdPhs7Mzgi1b3PbJe9PPZ6trN63/bUUUcPGkqnrev0yJ9Ku6B02r JUoDXClWTRnLALytqmIxQ09z3n59ihWJDZ1tFlaZTlaw4masmrqqaWA1HGXgLQHxSTai KU8xwf3foaZhEU5nhau/3rJe7XH0CsH8CMzxw= From: Frederic Weisbecker To: LKML Cc: LKML , Frederic Weisbecker , Arnd Bergmann , Thomas Gleixner , Andrew Morton , John Kacur , KAMEZAWA Hiroyuki , Al Viro , Ingo Molnar Subject: [PATCH 3/6] procfs: Use generic_file_llseek in /proc/kmsg Date: Tue, 30 Mar 2010 08:20:12 +0200 Message-Id: <1269930015-863-4-git-send-regression-fweisbec@gmail.com> X-Mailer: git-send-email 1.6.2.3 In-Reply-To: <1269930015-863-1-git-send-regression-fweisbec@gmail.com> References: <1269930015-863-1-git-send-regression-fweisbec@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No need to hold the bkl to seek here, none of the other fops callbacks use it. Use generic_file_llseek explicitly. Signed-off-by: Frederic Weisbecker Cc: Arnd Bergmann Cc: Thomas Gleixner Cc: Andrew Morton Cc: Ingo Molnar Cc: John Kacur Cc: KAMEZAWA Hiroyuki Cc: Al Viro --- fs/proc/kmsg.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/proc/kmsg.c b/fs/proc/kmsg.c index cfe90a4..bd4b5a7 100644 --- a/fs/proc/kmsg.c +++ b/fs/proc/kmsg.c @@ -53,6 +53,7 @@ static const struct file_operations proc_kmsg_operations = { .poll = kmsg_poll, .open = kmsg_open, .release = kmsg_release, + .llseek = generic_file_llseek, }; static int __init proc_kmsg_init(void) -- 1.6.2.3