From: Mark Asselstine <asselsm@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [PATCH] mmc: sd: Cleanup redundant memset
Date: Thu, 08 Apr 2010 00:40:56 +0000 [thread overview]
Message-ID: <1270687256-17061-1-git-send-email-asselsm@gmail.com> (raw)
The clearing of mrq via a memset at the top of the for loop in
mmc_wait_for_app_cmd() is not required as mrq is not used and
there is another clearing of mrq just below. We remove the first
memset since if the initial tests in the for loop fail the memset
is not required.
Signed-off-by: Mark Asselstine <asselsm@gmail.com>
---
drivers/mmc/core/sd_ops.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/core/sd_ops.c b/drivers/mmc/core/sd_ops.c
index 0d96080..63772e7 100644
--- a/drivers/mmc/core/sd_ops.c
+++ b/drivers/mmc/core/sd_ops.c
@@ -79,8 +79,6 @@ int mmc_wait_for_app_cmd(struct mmc_host *host, struct mmc_card *card,
* we cannot use the retries field in mmc_command.
*/
for (i = 0;i <= retries;i++) {
- memset(&mrq, 0, sizeof(struct mmc_request));
-
err = mmc_app_cmd(host, card);
if (err) {
/* no point in retrying; no APP commands allowed */
--
1.7.0
next reply other threads:[~2010-04-08 0:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 0:40 Mark Asselstine [this message]
2010-04-09 3:15 ` [PATCH] mmc: sd: Cleanup redundant memset Mark Asselstine
2010-04-09 3:15 ` Mark Asselstine
2010-04-18 18:38 ` Dan Carpenter
2010-04-19 19:51 ` Mark Asselstine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270687256-17061-1-git-send-email-asselsm@gmail.com \
--to=asselsm@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.