From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carlos Santa Subject: Re: [PATCH v4 2/5] drm/i915: Watchdog timeout: IRQ handler for gen8+ Date: Sun, 17 Mar 2019 17:15:14 -0700 Message-ID: <1271220339df25098eb6305051972c80c125bc52.camel@intel.com> References: <20190221025820.28447-1-carlos.santa@intel.com> <20190221025820.28447-3-carlos.santa@intel.com> <155143298308.5847.17161978101892410437@skylake-alporthouse-com> <62d65486-a45a-7cf9-1574-1c961be2ee9a@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9840089740 for ; Mon, 18 Mar 2019 00:15:52 +0000 (UTC) In-Reply-To: <62d65486-a45a-7cf9-1574-1c961be2ee9a@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Michel Thierry List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyMDE5LTAzLTExIGF0IDEwOjM5ICswMDAwLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToK PiBPbiAwOC8wMy8yMDE5IDAzOjE2LCBDYXJsb3MgU2FudGEgd3JvdGU6Cj4gPiBPbiBGcmksIDIw MTktMDMtMDEgYXQgMDk6MzYgKzAwMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiA+ID4gPiAKPiA+ ID4gCj4gPiA+IFF1b3RpbmcgQ2FybG9zIFNhbnRhICgyMDE5LTAyLTIxIDAyOjU4OjE2KQo+ID4g PiA+ICsjZGVmaW5lIEdFTjhfV0FUQ0hET0dfMTAwMFVTKGRldl9wcml2KQo+ID4gPiA+IHdhdGNo ZG9nX3RvX2Nsb2NrX2NvdW50cyhkZXZfcHJpdiwgMTAwMCkKPiA+ID4gPiArc3RhdGljIHZvaWQg Z2VuOF93YXRjaGRvZ19pcnFfaGFuZGxlcih1bnNpZ25lZCBsb25nIGRhdGEpCj4gPiA+ID4gK3sK PiA+ID4gPiArICAgICAgIHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSA9IChzdHJ1Y3QK PiA+ID4gPiBpbnRlbF9lbmdpbmVfY3MKPiA+ID4gPiAqKWRhdGE7Cj4gPiA+ID4gKyAgICAgICBz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBlbmdpbmUtPmk5MTU7Cj4gPiA+ID4g KyAgICAgICB1bnNpZ25lZCBpbnQgaHVuZyA9IDA7Cj4gPiA+ID4gKyAgICAgICB1MzIgY3VycmVu dF9zZXFubz0wOwo+ID4gPiA+ICsgICAgICAgY2hhciBtc2dbODBdOwo+ID4gPiA+ICsgICAgICAg dW5zaWduZWQgaW50IHRtcDsKPiA+ID4gPiArICAgICAgIGludCBsZW47Cj4gPiA+ID4gKwo+ID4g PiA+ICsgICAgICAgLyogU3RvcCB0aGUgY291bnRlciB0byBwcmV2ZW50IGZ1cnRoZXIgdGltZW91 dAo+ID4gPiA+IGludGVycnVwdHMKPiA+ID4gPiAqLwo+ID4gPiA+ICsgICAgICAgSTkxNV9XUklU RV9GVyhSSU5HX0NOVFIoZW5naW5lLT5tbWlvX2Jhc2UpLAo+ID4gPiA+IGdldF93YXRjaGRvZ19k aXNhYmxlKGVuZ2luZSkpOwo+ID4gPiA+ICsKPiA+ID4gPiArICAgICAgIC8qIFJlYWQgdGhlIGhl YXJ0YmVhdCBzZXFubyBvbmNlIGFnYWluIHRvIGNoZWNrIGlmIHdlCj4gPiA+ID4gYXJlCj4gPiA+ ID4gc3R1Y2s/ICovCj4gPiA+ID4gKyAgICAgICBjdXJyZW50X3NlcW5vID0KPiA+ID4gPiBpbnRl bF9lbmdpbmVfZ2V0X2hhbmdjaGVja19zZXFubyhlbmdpbmUpOwo+ID4gPiAKPiA+ID4gSSBoYXZl IHNhaWQgdGhpcyBiZWZvcmUsIGJ1dCB0aGlzIGRvZXNuJ3QgZXhpc3QgZWl0aGVyLCBpdCdzIGp1 c3QKPiA+ID4gYQo+ID4gPiB0ZW1wb3JhcnkgZ2xpdGNoIGluIHRoZSBtYXRyaXguCj4gPiA+IAo+ ID4gCj4gPiBDaHJpcywgVHZydGtvLCBJIG5lZWQgc29tZSBndWlkYW5jZSBvbiBob3cgdG8gZmlu ZCB0aGUgcXVpbHR5IHNlcW5vCj4gPiBkdXJpbmcgYSBoYW5nLCBjYW4geW91IHBsZWFzZSBhZHZp Y2UgaGVyZSB3aGF0IHRvIGRvPwo+IAo+IFdoZW4gYW4gaW50ZXJydXB0IGZpcmVzIHlvdSBuZWVk IHRvIGFzY2VydGFpbiB3aGV0aGVyIHRoZSBzYW1lCj4gcmVxdWVzdCAKPiB3aGljaCBlbmFibGVk IHRoZSB3YXRjaGRvZyBpcyBydW5uaW5nLCBjb3JyZWN0Pwo+IAo+IFNvIEkgdGhpbmsgeW91IHdv dWxkIG5lZWQgdGhpcywgd2l0aCBhIGRpc2NsYWltZXIgdGhhdCBJIGhhdmVuJ3QKPiB0aG91Z2h0 IAo+IGFib3V0IHRoZSBkZXRhaWxzIHJlYWxseToKPiAKPiAxLiBUYWtlIGEgcmVmZXJlbmNlIHRv IHRpbWVsaW5lIGh3c3Agd2hlbiBzZXR0aW5nIHVwIHRoZSB3YXRjaGRvZyBmb3IKPiBhIAo+IHJl cXVlc3QuCj4gCj4gMi4gU3RvcmUgdGhlIGluaXRpYWwgc2Vxbm8gYXNzb2NpYXRlZCB3aXRoIHRo aXMgcmVxdWVzdC4KPiAKPiAzLiBGb3JjZSBlbmFibGUgdXNlciBpbnRlcnJ1cHRzLgo+IAo+IDQu IFdoZW4gdGltZW91dCBmaXJlcywgaW5zcGVjdCB0aGUgSFdTUCBzZXFubyB0byBzZWUgaWYgdGhl IHJlcXVlc3QgCj4gY29tcGxldGVkIG9yIG5vdC4KPiAKPiA1LiBSZXNldCB0aGUgZW5naW5lIGlm IG5vdCBjb21wbGV0ZWQuCj4gCj4gNi4gUHV0IHRoZSB0aW1lbGluZS9od3NwIHJlZmVyZW5jZS4K CgpzdGF0aWMgaW50IGdlbjhfZW1pdF9iYl9zdGFydChzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycSwK CQkJCQkJCXU2NCBvZmZzZXQsIHUzMgpsZW4sCgkJCQkJCQljb25zdCB1bnNpZ25lZAppbnQgZmxh Z3MpCnsKCXN0cnVjdCBpOTE1X3RpbWVsaW5lICp0bDsKCXUzMiBzZXFubzsKCglpZiAoZW5hYmxl X3dhdGNoZG9nKSB7CgkJLyogU3RhcnQgd2F0Y2hkb2cgdGltZXIgKi8KCQljcyA9IGdlbjhfZW1p dF9zdGFydF93YXRjaGRvZyhycSwgY3MpOwoJCXRsID0gY2UtPnJpbmctPnRpbWVsaW5lOwoJCWk5 MTVfdGltZWxpbmVfZ2V0X3NlcW5vKHRsLCBycSwgJnNlcW5vKTsKCQkvKlN0b3JlIGluaXRpYWwg aHdzcCBzZXFubyBhc3NvY2lhdGVkIHdpdGggdGhpcyByZXF1ZXN0IAoJCWVuZ2luZS0+d2F0Y2hk b2dfaHdzcF9zZXFubyA9IHRsLT5od3NwX3NlcW5vOwoJfQoKfQoKc3RhdGljIHZvaWQgZ2VuOF93 YXRjaGRvZ190YXNrbGV0KHVuc2lnbmVkIGxvbmcgZGF0YSkKewoJCXN0cnVjdCBpOTE1X3JlcXVl c3QgKnJxOwoKCQlycSA9IGludGVsX2VuZ2luZV9maW5kX2FjdGl2ZV9yZXF1ZXN0KGVuZ2luZSk7 CgoJCS8qIEluc3BlY3QgdGhlIHdhdGNoZG9nIHNlcW5vIG9uY2UgYWdhaW4gZm9yCmNvbXBsZXRp b24/ICovCgkJaWYgKCFpOTE1X3NlcW5vX3Bhc3NlZChlbmdpbmUtPndhdGNoZG9nX2h3c3Bfc2Vx bm8sIHJxLQo+ZmVuY2Uuc2Vxbm8pKSB7CgkJCS8vUmVzZXQgRW5naW5lCgkJfQp9CgpUdnJ0a28s IGlzIHRoZSBhYm92ZSBhY2NlcHRhYmxlIHRvIGluc3BlY3Qgd2hldGhlciB0aGUgc2Vxbm8gaGFz CmNvbXBsZXRlZD8KCkkgbm90aWNlZCB0aGVyZSdzIGEgaGVscGVyIGZ1bmN0aW9uIGk5MTVfcmVx dWVzdF9jb21wbGV0ZWQoc3RydWN0Cmk5MTVfcmVxdWVzdCAqcnEpIGJ1dCBpdCB3aWxsIHJlcXVp cmUgbWUgdG8gbW9kaWZ5IGl0IGluIG9yZGVyIHRvIHBhc3MKMiBkaWZmZXJlbnQgc2Vxbm9zLgoK UmVnYXJkcywKQ2FybG9zCgo+IAo+IElmIHRoZSB1c2VyIGludGVycnVwdCBmaXJlcyB3aXRoIHRo ZSByZXF1ZXN0IGNvbXBsZXRlZCBjYW5jZWwgdGhlCj4gYWJvdmUgCj4gb3BlcmF0aW9ucy4KPiAK PiBUaGVyZSBjb3VsZCBiZSBhbiBpbmhlcmVudCByYWNlIGJldHdlZW4gaW5zcGVjdGluZyB0aGUg c2Vxbm8gYW5kIAo+IGRlY2lkaW5nIHRvIHJlc2V0LiBOb3Qgc3VyZSBhdCB0aGUgbW9tZW50IHdo YXQgdG8gZG8uIE1heWJlIGp1c3QgY2FsbAo+IGl0IAo+IGJhZCBsdWNrPwo+IAo+IEkgYWxzbyB0 aGluayBmb3IgdGhlIHNvZnR3YXJlIGltcGxlbWVudGF0aW9uIHlvdSBuZWVkIHRvIGZvcmNlIG5v IAo+IHJlcXVlc3QgY29hbGVzY2luZyBmb3IgY29udGV4dHMgd2l0aCB0aW1lb3V0IHNldC4gQmVj YXVzZSB5b3Ugd2FudAo+IHRvIAo+IGhhdmUgMTAwJSBkZWZpbmVkIGJvcmRlcnMgZm9yIHJlcXVl c3QgaW4gYW5kIG91dCAtIHNpbmNlIHRoZSB0aW1lb3V0Cj4gaXMgCj4gZGVmaW5lZCBwZXIgcmVx dWVzdC4KPiAKPiBJbiB0aGlzIGNhc2UgeW91IGRvbid0IG5lZWQgdGhlIHVzZXIgaW50ZXJydXB0 IGZvciB0aGUgdHJhaWxpbmcgZWRnZSAKPiBzaWduYWwgYnV0IGNhbiB1c2UgY29udGV4dCBjb21w bGV0ZS4gTWF5YmUgcHV0dGluZyBob29rcyBpbnRvIAo+IGNvbnRleHRfaW4vb3V0IGluIGludGVs X2xyYy5jIHdvdWxkIHdvcmsgdW5kZXIgdGhlc2UgY2lyY3Vtc3RhbmNlcy4KPiAKPiBBbHNvIGlm IHByZWVtcHRlZCB5b3UgbmVlZCB0byBjYW5jZWwgdGhlIHRpbWVyIHNldHVwIGFuZCBzdG9yZQo+ IGVsYXBzZWQgCj4gZXhlY3V0aW9uIHRpbWUuCj4gCj4gT3IgaXQgbWF5IG1ha2Ugc2Vuc2UgdG8g anVzdCBkaXNhYmxlIHByZWVtcHRpb24gZm9yIHRoZXNlIGNvbnRleHRzLiAKPiBPdGhlcndpc2Ug dGhlcmUgaXMgbm8gcG9pbnQgaW4gdHJ5aW5nIHRvIG1hbmRhdGUgdGhlIHRpbWVvdXQ/Cj4gCj4g QnV0IGl0IGlzIGFsc28ga2luZCBvZiBiYWQgc2luY2Ugbm9uLXByaXZpbGVnZWQgY29udGV4dHMg Y2FuIG1ha2UgCj4gdGhlbXNlbHZlcyBub24tcHJlZW1wdGFibGUgYnkgc2V0dGluZyB0aGUgd2F0 Y2hkb2cgdGltZW91dC4KPiAKPiBNYXliZSBhcyBhIGNvbXByb21pc2Ugd2UgbmVlZCB0byBhdXRv bWF0aWNhbGx5IGFwcGx5IGFuIGVsZXZhdGVkIAo+IHByaW9yaXR5IGxldmVsLCBidXQgbm90IGFz IGhpZ2ggdG8gYmUgY29tcGxldGVseSBub24tcHJlZW1wdGFibGUuCj4gU291bmRzIAo+IGxpa2Ug YSBoYXJkIHF1ZXN0aW9uLgo+IAo+IFJlZ2FyZHMsCj4gCj4gVHZydGtvCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=