From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Tyser Date: Wed, 21 Apr 2010 07:11:22 -0500 Subject: [U-Boot] [PATCH 12/17] SPEAr : i2c driver moved completely into drivers/i2c In-Reply-To: <1271836483-15978-13-git-send-email-vipin.kumar@st.com> References: <1271836483-15978-1-git-send-email-vipin.kumar@st.com> <1271836483-15978-2-git-send-email-vipin.kumar@st.com> <1271836483-15978-3-git-send-email-vipin.kumar@st.com> <1271836483-15978-4-git-send-email-vipin.kumar@st.com> <1271836483-15978-5-git-send-email-vipin.kumar@st.com> <1271836483-15978-6-git-send-email-vipin.kumar@st.com> <1271836483-15978-7-git-send-email-vipin.kumar@st.com> <1271836483-15978-8-git-send-email-vipin.kumar@st.com> <1271836483-15978-9-git-send-email-vipin.kumar@st.com> <1271836483-15978-10-git-send-email-vipin.kumar@st.com> <1271836483-15978-11-git-send-email-vipin.kumar@st.com> <1271836483-15978-12-git-send-email-vipin.kumar@st.com> <1271836483-15978-13-git-send-email-vipin.kumar@st.com> Message-ID: <1271851882.22118.24.camel@ptyser-laptop> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Vipin, On Wed, 2010-04-21 at 13:24 +0530, Vipin KUMAR wrote: > The i2c IP used by spear platform is a synopsys i2c controller > The earlier driver adds the driver of this controller as if it is > specific to > spear platform. > The driver files are now moved into drivers/i2c folder for reusability > by other > platforms > > Signed-off-by: Vipin Kumar > --- > arch/arm/include/asm/arch-spear/spr_i2c.h | 146 ------------- > drivers/i2c/Makefile | 2 +- > drivers/i2c/dw_i2c.c | 331 > +++++++++++++++++++++++++++++ I'd similarly lean towards naming the new file designware.c, or synopsis.c. It looks like the rest of the i2c drivers use a _i2c suffix, so I guess designware_i2c.c or synopsis_i2c.c would be best for consistency's sake. At a minimum it'd be nice to mention in the dw_i2c.c file what silicon the driver supports as right now a user needs to guess what "dw_i2c.c" runs on based solely on "dw". When you create patches with git format-patch, its nice to use the -M and -C to detect renames/copies. It makes the patch much smaller and much easier to review what actually changed. Best, Peter