All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julian Braha <julianbraha@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] drivers: pinctrl: qcom: fix Kconfig dependency on GPIOLIB
Date: Mon, 29 Mar 2021 12:41:50 -0400	[thread overview]
Message-ID: <12736456.GqETC5XQ6s@ubuntu-mate-laptop> (raw)
In-Reply-To: <CACRpkda2Jbm3DmOhxFyyxDZRrUk01TtPbD+OOG=U7o2mnxEB8A@mail.gmail.com>

On Tuesday, March 2, 2021 9:46:04 AM EDT you wrote:
> On Thu, Feb 25, 2021 at 9:33 AM Julian Braha <julianbraha@gmail.com> wrote:
> 
> > When PINCTRL_MSM is enabled, and GPIOLIB is disabled,
> > Kbuild gives the following warning:
> >
> > WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP
> >   Depends on [n]: GPIOLIB [=n]
> >   Selected by [y]:
> >   - PINCTRL_MSM [=y] && PINCTRL [=y] && (ARCH_QCOM || COMPILE_TEST [=y])
> >
> > This is because PINCTRL_MSM selects GPIOLIB_IRQCHIP,
> > without selecting or depending on GPIOLIB, despite
> > GPIOLIB_IRQCHIP depending on GPIOLIB. Having PINCTRL_MSM
> > select GPIOLIB will cause a recursive dependency error.
> >
> > Signed-off-by: Julian Braha <julianbraha@gmail.com>
> 
> Does it work to just:
> 
> select GPIOLIB
> 
> instead?
> 
> The driver needs the library so...
> 
> Yours,
> Linus Walleij
> 

Hi Linus,

Looks like I confused this patch with another one when 
I responded last time. This config option cannot select 
GPIOLIB, because it will cause a recursive dependency 
error.

Any other ideas?

- Julian Braha




  reply	other threads:[~2021-03-29 16:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25  8:33 [PATCH v1] drivers: pinctrl: qcom: fix Kconfig dependency on GPIOLIB Julian Braha
2021-03-02 14:46 ` Linus Walleij
2021-03-29 16:41   ` Julian Braha [this message]
2021-04-08  8:03     ` Linus Walleij
2021-04-14  2:33       ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12736456.GqETC5XQ6s@ubuntu-mate-laptop \
    --to=julianbraha@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.