Re: [linux-pm] [PATCH v4] pm_qos: make update_request non blocking

[James Bottomley <James.Bottomley@suse.de>]

On Thu, 2010-06-10 at 09:45 +0200, Florian Mickler wrote:
> On Wed, 09 Jun 2010 13:05:49 -0400
> James Bottomley <James.Bottomley@suse.de> wrote:
> > On Wed, 2010-06-09 at 18:32 +0200, Florian Mickler wrote:
> > > On Wed, 09 Jun 2010 12:07:25 -0400
> > > James Bottomley <James.Bottomley@suse.de> wrote:
> > > > OK, so the expression of the race is that the latest notification gets
> > > > lost.  If something is tracking values, you'd really like to lose the
> > > > previous one (which is now irrelevant) not the latest one.  The point is
> > > > there's still a race.
> > > > 
> > > > James
> > > > 
> > > 
> > > Yeah, but for blocking notification it is not that bad. 
> > 
> > The network latency notifier uses the value to recalculate something.
> > Losing the last value will mean it's using stale data.
> 
> Actually after pondering a bit, it is not stale data that gets
> delivered: (Correct me if I'm wrong)
> 
> The update_notify() function determines the extreme value and then
> calls the blocking_notifier_chain. 
> 
> But just before the update_notify() function get's called, the
> work-structure is reset and re-queue-able. So it is possible to queue it
> already even before the extreme_value in update_notify get's
> determined. 
> 
> So the notified value is always the latest or there is another
> notification underway.

Well, no ... it's a race, and like all good races the winner is non
deterministic.

If the update comes in before the work queue is run, then everyone
eventually sees the new value.  If it comes in as the chain is running,
some notifiers see the old value and some the new.  If it comes in
during back end processing, no-one sees the new value.

James