From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756158Ab0FNLDd (ORCPT ); Mon, 14 Jun 2010 07:03:33 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:48704 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756085Ab0FNLDc (ORCPT ); Mon, 14 Jun 2010 07:03:32 -0400 Subject: [PATCH] mtd: Fix bug using smp_processor_id() in preemptible ubi_bgt1d kthread From: Philby John Reply-To: pjohn@mvista.com To: linux-mtd@lists.infradead.org Cc: Artem Bityutskiy , David Daney , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Content-Type: text/plain Date: Mon, 14 Jun 2010 16:34:17 +0530 Message-Id: <1276513457.16642.3.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-2.fc10) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org mtd: Fix bug using smp_processor_id() in preemptible ubi_bgt1d kthread On a MIPS Cavium Octeon CN5020 when trying to create a UBI volume, on the NOR flash, the kernel thread ubi_bgt1d calls cfi_amdstd_write_buffers() --> do_write_buffer() --> INVALIDATE_CACHE_UDELAY --> __udelay(). Its __udelay() that calls smp_processor_id() in preemptible code, which you are not supposed to. Fix the problem by disabling preemption. The kernel error messages seen when trying to create UBI volume is BUG: using smp_processor_id() in preemptible [00000000] code: ubi_bgt1d/843 caller is __udelay+0x14/0x70 Call Trace: [] dump_stack+0x8/0x34 [] debug_smp_processor_id+0x114/0x130 [] __udelay+0x14/0x70 [] cfi_amdstd_write_buffers+0xa9c/0xd70 [] ubi_io_sync_erase+0x248/0x390 [] erase_worker+0x6c/0x4f8 [] do_work+0xac/0x138 [] ubi_thread+0x118/0x1a8 [] kthread+0x88/0x90 [] kernel_thread_helper+0x10/0x18 Signed-off-by: Philby John --- include/linux/mtd/cfi.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux/mtd/cfi.h b/include/linux/mtd/cfi.h index 574d9ee..9673213 100644 --- a/include/linux/mtd/cfi.h +++ b/include/linux/mtd/cfi.h @@ -495,7 +495,9 @@ static inline void cfi_udelay(int us) if (us >= 1000) { msleep((us+999)/1000); } else { + preempt_disable(); udelay(us); + preempt_enable(); cond_resched(); } } -- 1.6.3.3.333.g4d53f From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pw0-f49.google.com ([209.85.160.49]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1OO7S1-0003gt-N4 for linux-mtd@lists.infradead.org; Mon, 14 Jun 2010 11:03:37 +0000 Received: by pwj6 with SMTP id 6so3054110pwj.36 for ; Mon, 14 Jun 2010 04:03:32 -0700 (PDT) Subject: [PATCH] mtd: Fix bug using smp_processor_id() in preemptible ubi_bgt1d kthread From: Philby John To: linux-mtd@lists.infradead.org Content-Type: text/plain Date: Mon, 14 Jun 2010 16:34:17 +0530 Message-Id: <1276513457.16642.3.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: linux-mips@linux-mips.org, David Daney , linux-kernel@vger.kernel.org, Artem Bityutskiy Reply-To: pjohn@mvista.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , mtd: Fix bug using smp_processor_id() in preemptible ubi_bgt1d kthread On a MIPS Cavium Octeon CN5020 when trying to create a UBI volume, on the NOR flash, the kernel thread ubi_bgt1d calls cfi_amdstd_write_buffers() --> do_write_buffer() --> INVALIDATE_CACHE_UDELAY --> __udelay(). Its __udelay() that calls smp_processor_id() in preemptible code, which you are not supposed to. Fix the problem by disabling preemption. The kernel error messages seen when trying to create UBI volume is BUG: using smp_processor_id() in preemptible [00000000] code: ubi_bgt1d/843 caller is __udelay+0x14/0x70 Call Trace: [] dump_stack+0x8/0x34 [] debug_smp_processor_id+0x114/0x130 [] __udelay+0x14/0x70 [] cfi_amdstd_write_buffers+0xa9c/0xd70 [] ubi_io_sync_erase+0x248/0x390 [] erase_worker+0x6c/0x4f8 [] do_work+0xac/0x138 [] ubi_thread+0x118/0x1a8 [] kthread+0x88/0x90 [] kernel_thread_helper+0x10/0x18 Signed-off-by: Philby John --- include/linux/mtd/cfi.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux/mtd/cfi.h b/include/linux/mtd/cfi.h index 574d9ee..9673213 100644 --- a/include/linux/mtd/cfi.h +++ b/include/linux/mtd/cfi.h @@ -495,7 +495,9 @@ static inline void cfi_udelay(int us) if (us >= 1000) { msleep((us+999)/1000); } else { + preempt_disable(); udelay(us); + preempt_enable(); cond_resched(); } } -- 1.6.3.3.333.g4d53f