From: Maxim Levitsky <maximlevitsky@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
linux-pm <linux-pm@lists.linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Philip Langdale <philipl@overt.org>
Subject: Re: [PATCH v2] MMC: fix all hangs related to mmc/sd card insert/removal during suspend/resume.
Date: Tue, 15 Jun 2010 02:48:33 +0300 [thread overview]
Message-ID: <1276559313.7837.41.camel@maxim-laptop> (raw)
In-Reply-To: <20100614155157.dca38e09.akpm@linux-foundation.org>
On Mon, 2010-06-14 at 15:51 -0700, Andrew Morton wrote:
> On Fri, 11 Jun 2010 22:19:55 +0300
> Maxim Levitsky <maximlevitsky@gmail.com> wrote:
>
> > If you don't use CONFIG_MMC_UNSAFE_RESUME, card will now be removed
> > in pm notified while userspace is still running.
> > Thus it will be possible to sync it propely.
>
> That paragraph is a disaster and I'm not sure that I understand it well
> enough to repair it. I think you wanted s/now/not/ and s/in/if/ and
> s/it will be/it will not be/. Or perhaps you didn't.
>
> Please send a comprehensible replacement.
>
Sure.
If you don't use CONFIG_MMC_UNSAFE_RESUME, as soon as you attempt to
suspend, the card will be removed, therefore this patch doesn't change
the behavior of this option.
However the removal will be done by pm notifier, which runs while
userspace is still not frozen and thus can freely use del_gendisk,
without the risk of deadlock which would happen otherwise.
If you do use
Best regards,
Maxim Levitsky
next prev parent reply other threads:[~2010-06-14 23:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 19:00 [PATCH] Fix the outstanding issue with hangs on insert/removal of mmc cards Maxim Levitsky
2010-06-11 19:16 ` Maxim Levitsky
2010-06-11 19:16 ` Maxim Levitsky
2010-06-11 19:19 ` [PATCH v2] MMC: fix all hangs related to mmc/sd card insert/removal during suspend/resume Maxim Levitsky
2010-06-11 19:19 ` Maxim Levitsky
2010-06-13 11:27 ` Maxim Levitsky
2010-06-13 11:27 ` Maxim Levitsky
2010-06-14 22:51 ` Andrew Morton
2010-06-14 23:48 ` Maxim Levitsky
2010-06-14 23:48 ` Maxim Levitsky [this message]
2010-06-14 22:51 ` Andrew Morton
2010-06-14 23:01 ` Andrew Morton
2010-06-14 23:01 ` Andrew Morton
2010-06-14 23:18 ` Maxim Levitsky
2010-06-14 23:18 ` Maxim Levitsky
2010-06-11 19:42 ` [PATCH] Fix the outstanding issue with hangs on insert/removal of mmc cards David Brownell
2010-06-11 19:42 ` [linux-pm] " David Brownell
2010-06-11 21:00 ` Alan Stern
2010-06-11 21:00 ` [linux-pm] " Alan Stern
2010-06-11 21:03 ` Maxim Levitsky
2010-06-11 21:03 ` [linux-pm] " Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276559313.7837.41.camel@maxim-laptop \
--to=maximlevitsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=philipl@overt.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.