All of lore.kernel.org
 help / color / mirror / Atom feed
From: stefano@stabellini.net
To: linux-kernel@vger.kernel.org
Cc: xen-devel@lists.xensource.com, Stefano.Stabellini@eu.citrix.com,
	sheng@linux.intel.com, ddutile@redhat.com, jeremy@goop.org,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [PATCH 08/13] Fix possible NULL pointer dereference in print_IO_APIC
Date: Mon, 21 Jun 2010 17:14:02 +0100	[thread overview]
Message-ID: <1277136847-13266-8-git-send-email-stefano@stabellini.net> (raw)
In-Reply-To: <alpine.DEB.2.00.1006211456360.18470@kaball-desktop>

From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Make sure chip_data is not NULL before accessing it (the VIRQ_TIMER
handler and virq handlers in general don't have any chip_data).

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
 arch/x86/kernel/apic/io_apic.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index eb2789c..c64499c 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -1732,6 +1732,8 @@ __apicdebuginit(void) print_IO_APIC(void)
 		struct irq_pin_list *entry;
 
 		cfg = desc->chip_data;
+		if (!cfg)
+			continue;
 		entry = cfg->irq_2_pin;
 		if (!entry)
 			continue;
-- 
1.7.0.4


  parent reply	other threads:[~2010-06-21 16:24 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-21 16:12 [PATCH 0/12] PV on HVM Xen Stefano Stabellini
2010-06-21 16:12 ` Stefano Stabellini
2010-06-21 16:13 ` [PATCH 01/13] Add support for hvm_op stefano
2010-06-21 16:13 ` [PATCH 02/13] early PV on HVM stefano
2010-06-21 16:13 ` [PATCH 03/13] evtchn delivery " stefano
2010-06-21 16:13 ` [PATCH 04/13] Xen PCI platform device driver stefano
2010-06-30 17:55   ` Konrad Rzeszutek Wilk
2010-06-30 17:55     ` Konrad Rzeszutek Wilk
2010-07-01 11:38     ` Stefano Stabellini
2010-06-21 16:13 ` [PATCH 05/13] Add suspend\resume support for PV on HVM guests stefano
2010-06-21 16:14 ` [PATCH 06/13] Allow xen platform pci device to be compiled as a module stefano
2010-06-21 16:14 ` [PATCH 0/12] PV on HVM Xen Stefano Stabellini
2010-06-21 16:14   ` Stefano Stabellini
2010-06-21 16:14 ` [PATCH 07/13] Fix find_unbound_irq in presence of ioapic irqs stefano
2010-06-21 16:14 ` stefano [this message]
2010-06-21 16:14 ` [PATCH 09/13] __setup_vector_irq: handle NULL chip_data stefano
2010-06-21 16:14 ` [PATCH 10/13] Do not try to disable hpet if it hasn't been initialized before stefano
2010-06-30 17:53   ` Konrad Rzeszutek Wilk
2010-06-30 17:53     ` Konrad Rzeszutek Wilk
2010-07-09  1:05     ` john stultz
2010-06-30 21:24   ` Venkatesh Pallipadi
2010-06-30 21:24     ` Venkatesh Pallipadi
2010-07-02 10:44   ` Paolo Bonzini
2010-07-02 10:44     ` Paolo Bonzini
2010-06-21 16:14 ` [PATCH 11/13] Use xen_vcpuop_clockevent, xen_clocksource and xen wallclock stefano
2010-07-01 19:41   ` Don Dutile
2010-07-02 17:17     ` Stefano Stabellini
2010-07-02 17:17       ` Stefano Stabellini
2010-06-21 16:14 ` [PATCH 12/13] Unplug emulated disks and nics stefano
2010-07-01 19:41   ` Don Dutile
2010-07-01 19:41     ` Don Dutile
2010-07-05 11:58     ` Stefano Stabellini
2010-07-07 20:01       ` Don Dutile
2010-07-08 13:13         ` Stefano Stabellini
2010-07-08 13:13           ` Stefano Stabellini
2010-07-08 19:57           ` [Xen-devel] " Don Dutile
2010-07-08 21:29             ` Ian Campbell
2010-07-08 21:29               ` Ian Campbell
2010-07-08 21:59               ` [Xen-devel] " Don Dutile
2010-07-09  8:02                 ` Ian Campbell
2010-07-09  8:02                   ` Ian Campbell
2010-07-09 10:54                   ` Stefano Stabellini
2010-07-09 10:54                     ` Stefano Stabellini
2010-07-09 13:42                     ` [Xen-devel] " Don Dutile
2010-06-21 16:14 ` [PATCH 13/13] Call HVMOP_pagetable_dying on exit_mmap stefano
2010-06-30 17:56 ` [PATCH 0/12] PV on HVM Xen Konrad Rzeszutek Wilk
2010-07-01 11:38   ` Stefano Stabellini
2010-07-01 19:43     ` [Xen-devel] " Dan Magenheimer
2010-07-02 10:43       ` Stefano Stabellini
2010-07-02 16:08         ` Dan Magenheimer
2010-07-02 17:14           ` Stefano Stabellini
2010-07-02 19:49             ` Dan Magenheimer
2010-07-02 19:49               ` Dan Magenheimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1277136847-13266-8-git-send-email-stefano@stabellini.net \
    --to=stefano@stabellini.net \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=ddutile@redhat.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sheng@linux.intel.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.