From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=51657 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ORu3W-0000dh-9U for qemu-devel@nongnu.org; Thu, 24 Jun 2010 17:33:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ORu3U-0001ZB-Q0 for qemu-devel@nongnu.org; Thu, 24 Jun 2010 17:33:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3526) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ORu3U-0001YK-JG for qemu-devel@nongnu.org; Thu, 24 Jun 2010 17:33:52 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5OLXmT9007949 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 24 Jun 2010 17:33:49 -0400 From: Luiz Capitulino Date: Thu, 24 Jun 2010 18:33:26 -0300 Message-Id: <1277415220-17810-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH v3 00/14]: QMP: Replace client argument checker List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com Current QMP's client argument checker code is more complex than it should be and has a flaw: it ignores unknown arguments. This series solves both problems by introducing a new, simple and ultra-poweful argument checker. This wasn't trivial to get right due to the number of errors combinations, so review is very appreciated. changelog --------- v2 -> v3 - Move all input object checking into qmp_check_input_obj() - Fix remaining problem with the handling of O-type arguments - Small renames suggested by Markus - Small cleanup in handle_qmp_command() v1 -> v2 - Introduce new iteration API and use it - Handle O-type correctly (I hope so) - Address several small issues found by Markus