Re: [PATCH] Fix etherboot option ROM loading

[Gianni Tedesco <gianni.tedesco@citrix.com>]

On Tue, 2010-06-29 at 13:22 +0100, Keir Fraser wrote:
> On 29/06/2010 13:01, "Gianni Tedesco (3P)" <gianni.tedesco@citrix.com>
> wrote:
> 
> > I suppose we could use a custom protocol to export a list of ID's for a
> > ROM. I would suggest a header that goes before the ROM so as not to
> > interfere with the standards-conforming bits. We'd just have to
> > special-case ethernet ROM handling a bit more in hvmloader.
> 
> Especially if there is some scripted way we could scrape the IDs out of the
> gpxe sources and into a customised header, this might be the best way to go.
>
> I don't know.. I suppose the alternative is to say that our gpxe build only
> supports our qemu build, adjust the advertised single PCI IDs to match up.
> The only way we'd see other IDs is if someone passed through a real device,
> and in that case there's no guarantee it'd be an e1000 or rtl8139 anyway. In
> which case they'd need to build their own gpxe image anyway.

True, but in fact, couldn't the ROM just be pulled from the device in
that case?

> So.... Perhaps this is all a big bunch of waste of time and we should just
> go with your first patch after all and be done? :-)
> 
>  -- Keir

Heh, I'd say so, you could always just add a list of PCI-ID based ROM
target-names in to the etherboot Makefile... All it does is to bloat the
hvmloader image a bit.

Gianni