From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753225Ab0GHGCN (ORCPT ); Thu, 8 Jul 2010 02:02:13 -0400 Received: from smtp.nokia.com ([192.100.105.134]:50440 "EHLO mgw-mx09.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752094Ab0GHGCL (ORCPT ); Thu, 8 Jul 2010 02:02:11 -0400 Subject: Re: [PATCH 1/2] mtd: m25p80: Fix false-positive probing From: Artem Bityutskiy Reply-To: dedekind1@gmail.com To: Anton Vorontsov Cc: David Woodhouse , Barry Song <21cnbao@gmail.com>, Andrew Morton , Mike Frysinger , David Brownell , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org, uclinux-dist-devel@blackfin.uclinux.org In-Reply-To: <20100622165734.GA20699@oksana.dev.rtsoft.ru> References: <20100622165545.GA10255@oksana.dev.rtsoft.ru> <20100622165734.GA20699@oksana.dev.rtsoft.ru> Content-Type: text/plain; charset="UTF-8" Date: Thu, 08 Jul 2010 08:57:24 +0300 Message-ID: <1278568644.12733.35.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.30.2 (2.30.2-1.fc13) Content-Transfer-Encoding: 8bit X-OriginalArrivalTime: 08 Jul 2010 06:01:23.0480 (UTC) FILETIME=[FE737980:01CB1E62] X-Nokia-AV: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2010-06-22 at 20:57 +0400, Anton Vorontsov wrote: > Since commit 18c6182bae0acca220ed6611f741034d563cd19f ("Rework > probing/JEDEC code"), m25p80 driver successfully registers chips > even if JEDEC probing fails. > > This was needed to support non-JEDEC flashes. Though, it appears > that some platforms (e.g. blackfin bf533 stamp[1]) used the old > behavior to detect if there's any flash connected, so the driver > have to fail on JEDEC probing errors. > > This patch restores the old behavior for JEDEC flashes, and adds > "-nonjedec" SPI device IDs for M25Pxx flashes, so that the kernel > still supports non-JEDEC flashes. > > [1] http://blackfin.uclinux.org/gf/project/uclinux-dist/tracker/?action=TrackerItemEdit&tracker_item_id=5975 > > Reported-by: Mingquan Pan > Reported-by: Barry Song <21cnbao@gmail.com> > Signed-off-by: Anton Vorontsov > --- Pushed both patches to my l2-mtd-2.6.git / dunno, added Mike's ack. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgw-mx03.nokia.com (smtp.nokia.com [192.100.122.230]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "smtp.nokia.com", Issuer "VeriSign Trust Network" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 318C3B6EEE for ; Thu, 8 Jul 2010 16:24:10 +1000 (EST) Received: from mgw-mx09.nokia.com ([192.100.105.134]) by mgw-mx03.nokia.com (Switch-3.3.3/Switch-3.3.3) with ESMTP id o6861uo2030095 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 8 Jul 2010 09:01:59 +0300 Subject: Re: [PATCH 1/2] mtd: m25p80: Fix false-positive probing From: Artem Bityutskiy To: Anton Vorontsov In-Reply-To: <20100622165734.GA20699@oksana.dev.rtsoft.ru> References: <20100622165545.GA10255@oksana.dev.rtsoft.ru> <20100622165734.GA20699@oksana.dev.rtsoft.ru> Content-Type: text/plain; charset="UTF-8" Date: Thu, 08 Jul 2010 08:57:24 +0300 Message-ID: <1278568644.12733.35.camel@localhost> Mime-Version: 1.0 Cc: David Brownell , Mike Frysinger , Barry Song <21cnbao@gmail.com>, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org, uclinux-dist-devel@blackfin.uclinux.org, Andrew Morton , David Woodhouse Reply-To: dedekind1@gmail.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2010-06-22 at 20:57 +0400, Anton Vorontsov wrote: > Since commit 18c6182bae0acca220ed6611f741034d563cd19f ("Rework > probing/JEDEC code"), m25p80 driver successfully registers chips > even if JEDEC probing fails. > > This was needed to support non-JEDEC flashes. Though, it appears > that some platforms (e.g. blackfin bf533 stamp[1]) used the old > behavior to detect if there's any flash connected, so the driver > have to fail on JEDEC probing errors. > > This patch restores the old behavior for JEDEC flashes, and adds > "-nonjedec" SPI device IDs for M25Pxx flashes, so that the kernel > still supports non-JEDEC flashes. > > [1] http://blackfin.uclinux.org/gf/project/uclinux-dist/tracker/?action=TrackerItemEdit&tracker_item_id=5975 > > Reported-by: Mingquan Pan > Reported-by: Barry Song <21cnbao@gmail.com> > Signed-off-by: Anton Vorontsov > --- Pushed both patches to my l2-mtd-2.6.git / dunno, added Mike's ack. -- Best Regards, Artem Bityutskiy (Артём Битюцкий)