All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: christ.li@gmail.com
Cc: jirislaby@gmail.com, Larry Finger <Larry.Finger@lwfinger.net>,
	linux-kernel@vger.kernel.org, linux-sparse@vger.kernel.org,
	Jiri Slaby <jslaby@suse.cz>
Subject: [PATCH 1/2] parser: fix and simplify support of asm goto
Date: Sat, 10 Jul 2010 10:39:21 +0200	[thread overview]
Message-ID: <1278751162-10053-1-git-send-email-jslaby@suse.cz> (raw)
In-Reply-To: <AANLkTikFmeXz9og4t98jm6QcAdRa6rIeCAv3oeFnTgd8@mail.gmail.com>

Christopher Li wrote:
> Yes, you caught me slacking off. It is time to cut a new release
> and flush all the bits into the official tree.

But include the patch below first, please. And maybe the second
one...

---

1) We now handle only "asm (volatile|goto)?", whereas
   "asm volatile? goto?" is correct.
2) We need to match only goto_ident, so do it explicitly against
   token->ident without match_idents.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---
 parse.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/parse.c b/parse.c
index caf10b9..dd7b1a4 100644
--- a/parse.c
+++ b/parse.c
@@ -1915,7 +1915,8 @@ static struct token *parse_asm_statement(struct token *token, struct statement *
 	stmt->type = STMT_ASM;
 	if (match_idents(token, &__volatile___ident, &__volatile_ident, &volatile_ident, NULL)) {
 		token = token->next;
-	} else if (match_idents(token, &goto_ident, NULL)) {
+	}
+	if (token->ident == &goto_ident) {
 		is_goto = 1;
 		token = token->next;
 	}
-- 
1.7.1



  reply	other threads:[~2010-07-10  8:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-09  1:52 Warning message when using sparse Larry Finger
2010-07-09 20:47 ` Jiri Slaby
2010-07-09 21:22   ` Larry Finger
2010-07-09 21:26     ` Jiri Slaby
2010-07-09 22:04       ` Christopher Li
2010-07-10  8:39         ` Jiri Slaby [this message]
2010-07-10 18:36           ` [PATCH 1/2] parser: fix and simplify support of asm goto Chris Li
2010-07-10 18:36             ` Chris Li
2010-07-10  8:39         ` [PATCH 2/2] parser: define __builtin_unreachable Jiri Slaby
2010-07-10  9:07           ` Josh Triplett
2010-07-13  7:52             ` Chris Li
2010-07-13  7:52               ` Chris Li
2010-07-13 18:12               ` Josh Triplett
2010-07-13 18:49                 ` Chris Li
2010-07-13 18:49                   ` Chris Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1278751162-10053-1-git-send-email-jslaby@suse.cz \
    --to=jslaby@suse.cz \
    --cc=Larry.Finger@lwfinger.net \
    --cc=christ.li@gmail.com \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sparse@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.