From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Chen Qi <Qi.Chen@windriver.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH 1/2] toolchain-shar-extract.sh: remove legacy .o files
Date: Thu, 23 Apr 2020 00:19:39 +0100 [thread overview]
Message-ID: <127a7d4591d9071eed0dafddb69bf8dc180cfba9.camel@linuxfoundation.org> (raw)
In-Reply-To: <20200422072838.27867-1-Qi.Chen@windriver.com>
On Wed, 2020-04-22 at 15:28 +0800, Chen Qi wrote:
> We want to make sure `make scripts prepare` succeed inside SDK. However,
> the legacy .o files under scripts/kconfig will introduce build error
> on some hosts, thus removing them.
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
> meta/files/toolchain-shar-extract.sh | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/meta/files/toolchain-shar-extract.sh b/meta/files/toolchain-shar-extract.sh
> index 04527f891f..61911e72c9 100644
> --- a/meta/files/toolchain-shar-extract.sh
> +++ b/meta/files/toolchain-shar-extract.sh
> @@ -286,6 +286,9 @@ if [ -e "$post_relocate" ]; then
> $SUDO_EXEC rm -f $post_relocate
> fi
>
> +# Remove legacy .o files to avoid kernel build failure
> +rm -f $target_sdk_dir/sysroots/*/usr/src/kernel/scripts/kconfig/*.o
> +
We should be removing these at SDK construction time, not at extraction
time, then the SDK is smaller and we don't have special cases in this
extraction script...
Cheers,
Richard
next prev parent reply other threads:[~2020-04-22 23:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 7:28 [OE-core][PATCH 1/2] toolchain-shar-extract.sh: remove legacy .o files Chen Qi
2020-04-22 7:28 ` [OE-core][PATCH 2/2] linux-yocto: add more support for SDK Chen Qi
2020-04-22 12:46 ` Bruce Ashfield
2020-04-22 23:19 ` Richard Purdie [this message]
2020-04-23 1:53 ` [OE-core][PATCH 1/2] toolchain-shar-extract.sh: remove legacy .o files Chen Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=127a7d4591d9071eed0dafddb69bf8dc180cfba9.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=Qi.Chen@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.