From: Michael Ellerman <michael@ellerman.id.au>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
ppc-dev <linuxppc-dev@lists.ozlabs.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-pci <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] PCI: MSI: Restore read_msi_msg_desc(); add get_cached_msi_msg_desc()
Date: Sun, 01 Aug 2010 16:23:45 +1000 [thread overview]
Message-ID: <1280643825.32151.2.camel@concordia> (raw)
In-Reply-To: <20100730094247.05cb070e@virtuousgeek.org>
[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]
On Fri, 2010-07-30 at 09:42 -0700, Jesse Barnes wrote:
> On Fri, 23 Jul 2010 14:56:28 +0100
> Ben Hutchings <bhutchings@solarflare.com> wrote:
>
> > commit 2ca1af9aa3285c6a5f103ed31ad09f7399fc65d7 "PCI: MSI: Remove
> > unsafe and unnecessary hardware access" changed read_msi_msg_desc() to
> > return the last MSI message written instead of reading it from the
> > device, since it may be called while the device is in a reduced
> > power state.
> >
> > However, the pSeries platform code really does need to read messages
> > from the device, since they are initially written by firmware.
> > Therefore:
> > - Restore the previous behaviour of read_msi_msg_desc()
> > - Add new functions get_cached_msi_msg{,_desc}() which return the
> > last MSI message written
> > - Use the new functions where appropriate
> >
> > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> > ---
> > Compile-tested only.
> >
>
> Applied to linux-next with Michael's ack, thanks. I hope it actually
> works, I didn't see a tested-by!
I assume Stephen has been using it, otherwise his linux-next boot tests
will all have been failing. Either way he'll test it when it gets into
linux-next proper.
cheers
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-08-01 6:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 0:22 linux-next: OOPS at bot time Stephen Rothwell
2010-07-23 0:22 ` Stephen Rothwell
2010-07-23 1:19 ` Ben Hutchings
2010-07-23 2:05 ` Michael Ellerman
2010-07-23 13:56 ` [PATCH] PCI: MSI: Restore read_msi_msg_desc(); add get_cached_msi_msg_desc() Ben Hutchings
2010-07-23 13:56 ` Ben Hutchings
2010-07-26 11:20 ` Michael Ellerman
2010-07-26 11:20 ` Michael Ellerman
2010-07-30 16:42 ` Jesse Barnes
2010-07-30 16:42 ` Jesse Barnes
2010-08-01 6:23 ` Michael Ellerman [this message]
2012-11-20 7:20 ` Benjamin Herrenschmidt
2012-11-20 7:20 ` Benjamin Herrenschmidt
2012-11-20 12:36 ` Ben Hutchings
2012-11-20 12:36 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280643825.32151.2.camel@concordia \
--to=michael@ellerman.id.au \
--cc=bhutchings@solarflare.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.