All of lore.kernel.org
 help / color / mirror / Atom feed
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 12/19] ARM: cam60: don't use __init for cam60_spi_{flash_platform_data, partitions}
Date: Thu,  5 Aug 2010 16:08:46 +0200	[thread overview]
Message-ID: <1281017333-5563-12-git-send-email-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20100805140813.GA13859@pengutronix.de>

These two structs are referenced by cam60_spi_devices.  The latter is
copied at init time to kmalloced memory and so the copy isn't freed after
booting.  So it must not contain references to .init memory.

This isn't noticed by modpost as cam60_spi_devices is in .init.data, too.

Noticed-by: Andrew Victor <avictor.za@gmail.com>
Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
---
 arch/arm/mach-at91/board-cam60.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-at91/board-cam60.c b/arch/arm/mach-at91/board-cam60.c
index 05c7072..44eb9f7 100644
--- a/arch/arm/mach-at91/board-cam60.c
+++ b/arch/arm/mach-at91/board-cam60.c
@@ -75,7 +75,7 @@ static struct at91_usbh_data __initdata cam60_usbh_data = {
  * SPI devices.
  */
 #if defined(CONFIG_MTD_DATAFLASH)
-static struct mtd_partition __initdata cam60_spi_partitions[] = {
+static struct mtd_partition cam60_spi_partitions[] = {
 	{
 		.name	= "BOOT1",
 		.offset	= 0,
@@ -98,7 +98,7 @@ static struct mtd_partition __initdata cam60_spi_partitions[] = {
 	},
 };
 
-static struct flash_platform_data cam60_spi_flash_platform_data __initdata = {
+static struct flash_platform_data cam60_spi_flash_platform_data = {
 	.name		= "spi_flash",
 	.parts		= cam60_spi_partitions,
 	.nr_parts	= ARRAY_SIZE(cam60_spi_partitions)
-- 
1.7.1

  parent reply	other threads:[~2010-08-05 14:08 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-23 19:58 [PATCH 01/11] ARM: cam60: move cam60_spi_devices to .init.data Uwe Kleine-König
2010-07-23 19:58 ` Uwe Kleine-König
2010-07-23 19:58 ` [PATCH 02/11] ARM: kirkwood: move qnap_tsx1x_register_flash() to .init.text Uwe Kleine-König
2010-07-23 19:58   ` Uwe Kleine-König
2010-07-24  2:37   ` Nicolas Pitre
2010-07-24  2:37     ` Nicolas Pitre
2010-07-23 19:58 ` [PATCH 03/11] ARM: sa1111: move __sa1111_probe() to .devinit.text Uwe Kleine-König
2010-07-23 19:58   ` Uwe Kleine-König
2010-07-23 20:23   ` Kristoffer Ericson
2010-07-23 20:23     ` Kristoffer Ericson
2010-07-23 19:58 ` [PATCH 04/11] ARM: omap: move omap_init_fb to .init.text Uwe Kleine-König
2010-07-23 19:58   ` Uwe Kleine-König
2010-07-23 19:58   ` Uwe Kleine-König
2010-07-23 19:58 ` [PATCH 05/11] ARM: omap1: nokia770: move mipid_dev_init() " Uwe Kleine-König
2010-07-23 19:58   ` Uwe Kleine-König
2010-07-23 19:58   ` Uwe Kleine-König
2010-07-23 19:58 ` [PATCH 06/11] ARM: omap: move omapfb_reserve_sdram() " Uwe Kleine-König
2010-07-23 19:58   ` Uwe Kleine-König
2010-07-23 19:58   ` Uwe Kleine-König
2010-07-23 21:15   ` Russell King - ARM Linux
2010-07-23 21:15     ` Russell King - ARM Linux
2010-07-23 21:15     ` Russell King - ARM Linux
2010-07-24  8:51     ` Uwe Kleine-König
2010-07-24  8:51       ` Uwe Kleine-König
2010-07-23 19:58 ` [PATCH 07/11] ARM: omap: move omapfb_reserve_sram() " Uwe Kleine-König
2010-07-23 19:58   ` Uwe Kleine-König
2010-07-23 19:58   ` Uwe Kleine-König
2010-07-23 21:15   ` Russell King - ARM Linux
2010-07-23 21:15     ` Russell King - ARM Linux
2010-07-23 21:15     ` Russell King - ARM Linux
2010-07-23 19:58 ` [PATCH 08/11] ARM: omap: move get_fbmem_region() " Uwe Kleine-König
2010-07-23 19:58   ` Uwe Kleine-König
2010-07-23 19:58   ` Uwe Kleine-König
2010-07-23 21:16   ` Russell King - ARM Linux
2010-07-23 21:16     ` Russell King - ARM Linux
2010-07-23 21:16     ` Russell King - ARM Linux
2010-07-23 19:58 ` [PATCH 09/11] ARM: omap: move omap_get_config et al. " Uwe Kleine-König
2010-07-23 19:58   ` Uwe Kleine-König
2010-07-23 19:58 ` [PATCH 10/11] wip: ARM: omap: move omap_board_config_kernel to .init.data Uwe Kleine-König
2010-07-23 19:58   ` Uwe Kleine-König
2010-07-23 19:58 ` [PATCH 11/11] ARM: omap: ams-delta: move config " Uwe Kleine-König
2010-07-23 19:58   ` Uwe Kleine-König
2010-07-23 19:58   ` Uwe Kleine-König
2010-08-01 21:23 ` [PATCH 01/11] ARM: cam60: move cam60_spi_devices " avictor.za
2010-08-01 21:23   ` avictor.za at gmail.com
2010-08-02  5:26   ` Uwe Kleine-König
2010-08-02  5:26     ` Uwe Kleine-König
2010-08-02  7:59     ` [PATCH] ARM: cam60: don't use __init for cam60_spi_{flash_platform_data, partitions} Uwe Kleine-König
2010-08-05 14:08 ` [PATCH 00/19] More section fixes [Was: Re: [PATCH 01/11] ARM: cam60: move cam60_spi_devices to .init.data] Uwe Kleine-König
2010-08-05 14:08   ` Uwe Kleine-König
2010-08-05 14:08   ` [PATCH 01/19] wip: enable DEBUG_SECTION_MISMATCH Uwe Kleine-König
2010-08-05 14:08   ` [PATCH 02/19] ARM: sa1111: move __sa1111_probe() to .devinit.text Uwe Kleine-König
2010-09-01 10:02     ` Uwe Kleine-König
2010-08-05 14:08   ` [PATCH 03/19] ARM: omap: move omap_init_fb to .init.text Uwe Kleine-König
2010-08-05 14:08   ` [PATCH 04/19] ARM: omap1: nokia770: move mipid_dev_init() " Uwe Kleine-König
2010-08-05 14:08   ` [PATCH 05/19] ARM: omap: move get_fbmem_region() " Uwe Kleine-König
2010-08-05 14:08   ` [PATCH 06/19] ARM: omap: move omap_get_config et al. " Uwe Kleine-König
2010-08-05 14:08   ` [PATCH 07/19] wip: ARM: omap: move omap_board_config_kernel to .init.data Uwe Kleine-König
2010-08-05 14:08   ` [PATCH 08/19] ARM: omap: ams-delta: move config " Uwe Kleine-König
2010-08-05 14:08   ` [PATCH 09/19] MTD: pxa2xx: move pxa2xx_flash_probe to .devinit.text Uwe Kleine-König
2010-08-05 14:08   ` [PATCH 10/19] VIDEO: sa1100fb: register driver using platform_driver_probe Uwe Kleine-König
2010-08-05 14:08   ` [PATCH 11/19] ARM: cam60: move cam60_spi_devices to .init.data Uwe Kleine-König
2010-08-10 19:33     ` avictor.za at gmail.com
2010-08-05 14:08   ` Uwe Kleine-König [this message]
2010-08-10 19:37     ` [PATCH 12/19] ARM: cam60: don't use __init for cam60_spi_{flash_platform_data, partitions} avictor.za at gmail.com
2010-08-05 14:08   ` [PATCH 13/19] usb gadget: don't save bind callback in struct usb_gadget_driver Uwe Kleine-König
2010-08-05 14:08   ` [PATCH 14/19] usb gadget: don't save bind callback in struct usb_configuration Uwe Kleine-König
2010-08-05 14:21     ` Uwe Kleine-König
2010-08-05 14:08   ` [PATCH 15/19] SPI: amba-pl022: move probe and remove to .devinit and .devexit resp Uwe Kleine-König
2010-08-05 17:14     ` Kevin Wells
2010-08-05 14:08   ` [PATCH 16/19] ARM: nomadik: register nmk_gpio_driver using platform_driver_probe Uwe Kleine-König
2010-08-09  6:59     ` Rabin VINCENT
2010-09-02 13:50       ` [PATCH] ARM: nomadik: move nmk_gpio_probe to .devinit.text Uwe Kleine-König
2010-09-02 14:55         ` Rabin Vincent
2010-09-02 15:13           ` (Patch #6347) " Uwe Kleine-König
2010-09-02 10:30     ` [PATCH 16/19] ARM: nomadik: register nmk_gpio_driver using platform_driver_probe Linus Walleij
2010-09-02 10:50       ` Uwe Kleine-König
2010-09-02 14:42       ` Russell King - ARM Linux
2010-08-05 14:08   ` [PATCH 17/19] ARM: s3c64xx: don't put smartq5_leds in .init.data Uwe Kleine-König
2010-08-05 14:08   ` [PATCH 18/19] ARM: s3c64xx: don't put smartq7_leds " Uwe Kleine-König
2010-08-05 14:08   ` [PATCH 19/19] ARM: s3c64xx: don't put smartq_bl_init in .init.text Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1281017333-5563-12-git-send-email-u.kleine-koenig@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.