From: Johannes Berg <johannes@sipsolutions.net>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: lrodriguez@atheros.com, linux-wireless@vger.kernel.org,
mcgrof@infradead.org
Subject: Re: [PATCH 2/4] compat: move va_format to compat-2.6.36.h
Date: Sun, 08 Aug 2010 10:01:43 +0200 [thread overview]
Message-ID: <1281254503.3697.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4C5D95C6.4060301@hauke-m.de>
On Sat, 2010-08-07 at 19:20 +0200, Hauke Mehrtens wrote:
> Am 07.08.2010 17:50, schrieb Johannes Berg:
> > On Sat, 2010-08-07 at 15:32 +0200, Hauke Mehrtens wrote:
> >> This struct was introduced in kernel 2.6.36 and not 2.6.35.
> >
> > I'm confused now:
> >
> > $ git describe 7db6f5fb
> > v2.6.35-rc1-928-g7db6f5f
> >
> > johannes
> >
> Hi,
>
> I am also confused. ;-) I get the same result for git describe 7db6f5fb
> as you.
>
> But include/linux/kernel.h does not contain struct va_format in kernel
> 2.6.35 it was added sometime later.
>
> Without adding struct va_format to compat-2.6.36.h I get build error
> with kernel 2.6.35.
Ok ... Hmm. I guess this patch got in multiple times or something, since
I can see it in wireless-testing that's based on .35 as well, which was
the reason we moved this to compat-2.6.35 because otherwise it failed
compilation there!
I'm starting to think that we should detect at compile time what
features are present, say by test-compiling a file that contains a use
of the struct.
johannes
next prev parent reply other threads:[~2010-08-08 8:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-07 13:32 [PATCH 0/4] compat: miscellaneous updates for compat Hauke Mehrtens
2010-08-07 13:32 ` [PATCH 1/4] compat: backport n_tty_ioctl_helper Hauke Mehrtens
2010-08-07 13:32 ` [PATCH 2/4] compat: move va_format to compat-2.6.36.h Hauke Mehrtens
2010-08-07 15:50 ` Johannes Berg
2010-08-07 17:20 ` Hauke Mehrtens
2010-08-08 8:01 ` Johannes Berg [this message]
2010-08-07 13:32 ` [PATCH 3/4] compat: fix compiler warning Hauke Mehrtens
2010-08-07 13:32 ` [PATCH 4/4] compat: update compat_firmware_class.c Hauke Mehrtens
2010-08-10 1:18 ` [PATCH 0/4] compat: miscellaneous updates for compat Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281254503.3697.1.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=mcgrof@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.